./xbps-src zap permission error after compiling with golang

[b-l-a-i-n-e]

After compiling a program with golang, a masterdir/tmp/go directory is created with files in it that can only only be removed as root.

./xpbs-src zap then complains about permissions like below

rm: cannot remove '/home/b/void-packages/masterdir/tmp/go/pkg/mod/golang.org/x/net@v0.0.0-20190328230028-74de082e2cca/dns/dnsmessage/example_test.go': Permission denied
rm: cannot remove '/home/b/void-packages/masterdir/tmp/go/pkg/mod/golang.org/x/net@v0.0.0-20190328230028-74de082e2cca/dns/dnsmessage/message_test.go': Permission denied
rm: cannot remove '/home/b/void-packages/masterdir/tmp/go/pkg/mod/golang.org/x/net@v0.0.0-20190328230028-74de082e2cca/dns/dnsmessage/message.go': Permission denied
rm: cannot remove '/home/b/void-packages/masterdir/tmp/go/pkg/mod/golang.org/x/net@v0.0.0-20190328230028-74de082e2cca/PATENTS': Permission denied

[b-l-a-i-n-e]

sudo rm -rf masterdir/tmp fixes it, but to avoid sudo permissions we may need to do something like

chmod -R 777 masterdir/tmp in the zap command

[b-l-a-i-n-e]

Potential fix here:
#34506

[paper42]

That is a solution, but a much cleaner approach would be to add -modcacherw to the go build style to make the files writeable

[b-l-a-i-n-e]

@paper42 do you mean adding the GOFLAGS check in the actual build_style (common/build-style/go.sh) or adding the flag to the specific package that was causing the issue?

For my particular issue I was not using the go build-style because the package I want to install is not in the normal go package format, I need to run a script to start the go compilation