zap: chmod -R needed to remove Go modules
#34506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please word the commit a bit more clearly. And a solution like d7bf8e0 would be welcome because it speeds things up considerably. In any case, we should be able to pass the necessary flags to Go to make this unnecessary. |
We need to `chmod -R` to clean up after Go packages if they get moved into the masterdir. But since the removal of go packages is unnecessary in most cases, we only run if the first `rm -rf` fails.
b-l-a-i-n-e
force-pushed
the
xbps-src-zap-34505
branch
from
fa3ecdc
to
26f0722
Compare
|
Thanks for taking a look @ericonr, I rebased and pushed up the changes you recommended |
b-l-a-i-n-e
changed the title
./xbps-src zap deletes all files in masterdirchmod -R needed to remove Go modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes