New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Control-C on ipython (on extension code using cysignals) is broken #35712
Comments
The issue is fixed by downgrading The issue is present with prompt_toolkit 3.0.26_1 so it seems to be a regression between 3.0.24 and 3.0.26 (I don't have 3.0.25 in my cache). |
There's a strong smell in the changelog for 3.0.25 and 3.0.26:
Edit: built 3.0.25 which is already broken. |
Reported upstream: prompt-toolkit/python-prompt-toolkit#1576 |
Correct behaviour (using python):
After running
a.factor()
I hit control-C (the statement takes ~ half hour to finish). Since this is running extension code (pari C library) python is not catching signals; that's why cypari uses cysignals which is supposed to catch the signal and raise theKeyboardInterrupt
.But when running the same code using ipython nothing happens:
This bug affects our sagemath which is using our system packages for ipython, cypari2, cysignals, etc. When using the vendored version of these packages in sagemath, this works ok:
It's possible that there's something about our packages that is breaking signal handling.
For the record, the package versions are:
Downgrading system ipython to 7.29.0 (which I happen to have in my cache) doesn't fix the issue. I will try to build cysignals-1.10.3 as a void package (since 1.11.2 is the first version to be shipped in void) and see if that changes anything.
The text was updated successfully, but these errors were encountered: