Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runit: Remove zsh completions #36593

Closed
foopub opened this issue Apr 9, 2022 · 5 comments · Fixed by #43162
Closed

runit: Remove zsh completions #36593

foopub opened this issue Apr 9, 2022 · 5 comments · Fixed by #43162
Labels

Comments

@foopub
Copy link
Contributor

foopub commented Apr 9, 2022

The file https://github.com/void-linux/void-packages/blob/master/srcpkgs/runit/files/_sv seems unnecessary as better completions are provided by the default https://github.com/zsh-users/zsh/blob/master/Completion/Unix/Command/_runit (which seems to have been created only a few months after in 2014... weird no one has noticed until now)

@foopub
Copy link
Contributor Author

foopub commented Apr 9, 2022

#28790
void-linux/runit#15
also seem relevant, but the template does seem to use the version provided in the files here:

	vinstall ${FILESDIR}/_sv 644 usr/share/zsh/site-functions

Any point opening the same issue in the void runit repo?

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@RunningDroid
Copy link
Contributor

Sorry for bumping a stale issue, but I wanted to point out that (after void-linux/runit#15 is merged) neither completion is better than the other (IMO.)
The completion from zsh-users has prettier prompts, but it doesn't ignore $SVDIR when using sudo*.
The completion that we (will) ship with runit (that we apparently have 2 copies of) ignores $SVDIR when using sudo*, but it has relatively minimalist prompts.
The good news is that the licenses between the two completions appears to be compatible, runit is licensed BSD-3-CLAUSE & the zsh-users completion appears to be licensed MIT, so we (aka void-linux/runit) can copy the fancy prompts but I don't think they can copy the sudo* detection without re-licensing their completions.

*:and su -c, and doas

@leahneukirchen
Copy link
Member

+1 for removing our completion.

triallax added a commit to triallax/void-packages that referenced this issue Apr 1, 2023
triallax added a commit to triallax/void-packages that referenced this issue Apr 1, 2023
triallax added a commit to triallax/void-packages that referenced this issue Apr 2, 2023
@github-actions
Copy link

Issues become stale 90 days after last activity and are closed 14 days after that. If this issue is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 19, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
leahneukirchen pushed a commit that referenced this issue Jun 16, 2023
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this issue Jun 27, 2023
rederick29 pushed a commit to rederick29/void-packages that referenced this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants