Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of packages failing to build due to a missing or broken Cargo.lock #43482

Closed
15 tasks done
paper42 opened this issue Apr 16, 2023 · 6 comments
Closed
15 tasks done
Labels
tracking for tracking larger sets of changes

Comments

@paper42
Copy link
Member

paper42 commented Apr 16, 2023

cc @jcgruenhage

@paper42 paper42 added the tracking for tracking larger sets of changes label Apr 16, 2023
@tranzystorekk
Copy link
Contributor

mandown: #43483

@tranzystorekk
Copy link
Contributor

cargo-license: #43493

@icp1994
Copy link
Contributor

icp1994 commented Apr 17, 2023

Maybe we can do a cleanup by adding a do_configure to the cargo build style.

do_configure() {
     cargo fetch --target ${RUST_TARGET} ${configure_args}
}

From the docs of cargo-fetch

If a Cargo.lock file is available, this command will ensure that all of the git dependencies and/or registry dependencies are downloaded and locally available. Subsequent Cargo commands will be able to run offline after a cargo fetch unless the lock file changes.

If the lock file is not available, then this command will generate the lock file before fetching the dependencies.

@tranzystorekk
Copy link
Contributor

This would defeat the point of the lockfile PR, which AFAIU was to make the packages that have lockfile problems more prominent.

@icp1994
Copy link
Contributor

icp1994 commented Apr 17, 2023

Oh, okay. I thought we are just (re-)generating the lockfile anyway - fex, bandwhich.

@jcgruenhage
Copy link
Contributor

jcgruenhage commented Apr 17, 2023

I'd like to rename this issue: In some of these cases, the Cargo.lock file is present, but not up to date. In the case of cargo-auditable` for example, it's just a tiny issue around the version number of itself:

diff --git a/Cargo.lock2 b/Cargo.lock
index 00969c9e1c..5caabbda1c 100644
--- a/Cargo.lock2
+++ b/Cargo.lock
@@ -72,7 +72,7 @@ dependencies = [
 
 [[package]]
 name = "cargo-auditable"
-version = "0.6.0"
+version = "0.6.1"
 dependencies = [
  "auditable-info",
  "auditable-serde",

cargo-auditable: #43498

@paper42 paper42 changed the title List of packages failing to build due to missing Cargo.lock List of packages failing to build due to a missing or broken Cargo.lock Apr 17, 2023
@paper42 paper42 mentioned this issue Jun 4, 2023
sirkhancision pushed a commit to sirkhancision/void-packages that referenced this issue Jun 27, 2023
rederick29 pushed a commit to rederick29/void-packages that referenced this issue Jun 29, 2023
hholst80 pushed a commit to hholst80/void-packages that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking for tracking larger sets of changes
Projects
None yet
Development

No branches or pull requests

4 participants