Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu-efi-libs > 3.0.15 breaks gummiboot build #49859

Closed
rbzchnadm opened this issue Apr 16, 2024 · 3 comments
Closed

gnu-efi-libs > 3.0.15 breaks gummiboot build #49859

rbzchnadm opened this issue Apr 16, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@rbzchnadm
Copy link

rbzchnadm commented Apr 16, 2024

Is this a new report?

Yes

System Info

Void 6.1.83_1 x86_64 GenuineIntel/VM notuptodate rFFF

Package(s) Affected

gummiboot-48.1_8

Does a report exist for this bug with the project's home (upstream) and/or another distro?

No response

Expected behaviour

Package must be built successfully

Actual behaviour

  CC       src/setup/gummiboot-efivars.o
In file included from /usr/include/efi/efi.h:46,
                 from src/efi/pefile.c:17:
/usr/include/efi/x86_64/efibind.h:99:10: fatal error: stddef.h: No such file or directory
   99 | #include <stddef.h>
      |          ^~~~~~~~~~
In file included from /usr/include/efi/efi.h:46,
                 from src/efi/graphics.c:20:
/usr/include/efi/x86_64/efibind.h:99:10: fatal error: stddef.h: No such file or directory
   99 | #include <stddef.h>
      |          ^~~~~~~~~~
In file included from /usr/include/efi/efi.h:46,
                 from src/efi/util.c:18:
/usr/include/efi/x86_64/efibind.h:99:10: fatal error: stddef.h: No such file or directory
   99 | #include <stddef.h>
      |          ^~~~~~~~~~
In file included from /usr/include/efi/efi.h:46,
                 from src/efi/console.c:18:
/usr/include/efi/x86_64/efibind.h:99:10: fatal error: stddef.h: No such file or directory
   99 | #include <stddef.h>
      |          ^~~~~~~~~~

Steps to reproduce

  1. xbps-src -N pkg gummiboot-efistub

  1. Reverting back gnu-efi-libs to version 3.0.15
  2. xbps-src -N pkg gummiboot-efistub
@rbzchnadm rbzchnadm added bug Something isn't working needs-testing Testing a PR or reproducing an issue needed labels Apr 16, 2024
@classabbyamp
Copy link
Member

related: https://git.alpinelinux.org/aports/tree/main/gummiboot/APKBUILD#n30

but alpine's solution doesn't appear to work on musl (and it wouldn't work on glibc because stddef.h is provided by gcc, not glibc)

@classabbyamp classabbyamp removed the needs-testing Testing a PR or reproducing an issue needed label Apr 16, 2024
@classabbyamp classabbyamp changed the title gnu-efi-libs > 3.0.15 breaks gummiboot gnu-efi-libs > 3.0.15 breaks gummiboot build Apr 16, 2024
@sgn
Copy link
Member

sgn commented Apr 17, 2024

Then our gcc is broken? since freestanding C implementation must provides stddef.h

@classabbyamp
Copy link
Member

gcc provides it but there's -nostdinc in the cmdline so I don't think it adds that header automatically

@sgn sgn closed this as completed in 1df68ce Apr 17, 2024
atweiden added a commit to atweiden/voidpkgs that referenced this issue Apr 18, 2024
gnu-efi-libs needs stddef.h now.
It should be ok to be included, even if in -ffreestanding,
systemd-boot also dropped -nostdinc.

Close: void-linux/void-packages#49859

void-linux/void-packages@1df68ce
snwnde pushed a commit to snwnde/void-packages that referenced this issue Apr 18, 2024
gnu-efi-libs needs stddef.h now.
It should be ok to be included, even if in -ffreestanding,
systemd-boot also dropped -nostdinc.

Close: void-linux#49859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants