Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbps-src: recompute XBPS_MASTERDIR and XBPS_HOSTDIR in chroot stage. #10299

Merged

Conversation

yopito
Copy link
Contributor

@yopito yopito commented Mar 27, 2019

fix Issue #8282

@pullmoll
Copy link
Member

pullmoll commented Mar 27, 2019

I still see an error message when using ./xbps -m /tmp/some/path … binary-bootstrap:

chmod: cannot access '/void-packages/masterdir/builddir': No such file or directory

from line xbps-src:716. Perhaps we should add --quiet or -f to the chmod params.

Also note that the option handling is -m) readonly XBPS_MASTERDIR=….
Wouldn't that need to be changed to an export XBPS_MASTERDIR=…?

@yopito
Copy link
Contributor Author

yopito commented Mar 28, 2019

Thanks for inputs. Additional rework is needed.

@yopito yopito changed the title xbps-src: recompute XBPS_MASTERDIR and XBPS_HOSTDIR in chroot stage. [WIP] xbps-src: recompute XBPS_MASTERDIR and XBPS_HOSTDIR in chroot stage. Mar 28, 2019
@yopito yopito force-pushed the xbps-src.chroot.MASTERDIR.HOSTDIR branch from 97d3c23 to d4bef77 Compare March 29, 2019 19:03
@yopito yopito changed the title [WIP] xbps-src: recompute XBPS_MASTERDIR and XBPS_HOSTDIR in chroot stage. xbps-src: recompute XBPS_MASTERDIR and XBPS_HOSTDIR in chroot stage. Mar 29, 2019
@yopito
Copy link
Contributor Author

yopito commented Mar 29, 2019

I'ts better now.

About -m) readonly XBPS_MASTERDIR=…. : I think export is still uneeded here, since It's already working in "normal" mode ?

the rationale for this tiny modification is that chrooted xbps-src is in fact a new process, launched without any option (see common/xbps-src/shutils/chroot.sh:221); so this patch should be sufficient at this time.

I don't often use all possible commands of xbps-src; I will try the one related to chroot this week-end just in case.

@yopito
Copy link
Contributor Author

yopito commented Apr 11, 2019

@pullmoll: I've fixed what you've found. Could you give a try again ? thx

@Hoshpak Hoshpak merged commit c15d859 into void-linux:master Jun 4, 2019
@yopito yopito deleted the xbps-src.chroot.MASTERDIR.HOSTDIR branch June 16, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants