Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: systemd-boot-241 #10469

Closed
wants to merge 1 commit into from
Closed

New package: systemd-boot-241 #10469

wants to merge 1 commit into from

Conversation

maxice8
Copy link
Contributor

@maxice8 maxice8 commented Apr 1, 2019

@the-maldridge
Copy link
Member

I personally am somewhat opposed to adding more bootloaders, but the template looks as well written as your others.

@Johnnynator
Copy link
Member

You wanted a comment, here is one :D

=> systemd-boot-241_1: running do_build ...
ninja: error: unknown target 'src/boot/efi/linuxx86.efi.stub'
=> ERROR: systemd-boot-241_1: do_build: 'ninja $targets' exited with 1
=> ERROR:   in do_build() at srcpkgs/systemd-boot/template:41
The command "common/travis/build.sh $BOOTSTRAP $ARCH" exited with 1.

Johnnynator
Johnnynator reviewed Apr 1, 2019
View reviewed changes
srcpkgs/systemd-boot/template Outdated
x86_64*) efi_arch=x64 ;;
armv*) efi_arch=arm ;;
aarch64*) efi_arch=aa64 ;;
i686*) efi_arch=x86 ;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a *) broken="efi_arch is not set";; Or does it have a generic src/boot/efi/linux.efi.stub target for ninja?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use the wrong name for the i686 arch mostlikely

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think broken is right here, I would prefer archs= as unsupported platforms not the same as broken platforms.

@q66
Copy link
Contributor

q66 commented Apr 1, 2019

You should make this "broken" for any arch not explicitly mentioned, or alternatively archs="x86_64 armv* aarch64 i686", EFI is not really present anywhere except on x86 and ARM.

@q66
Copy link
Contributor

q66 commented Apr 1, 2019

I looked in the buildsystem. The allowed names are ia32, x64, arm, and aa64, there isn't anything else

@maxice8
Copy link
Contributor Author

maxice8 commented Apr 1, 2019

fixed

@q66
Copy link
Contributor

q66 commented Apr 1, 2019

:shipit:

@maxice8
Copy link
Contributor Author

maxice8 commented Apr 1, 2019

Is there interest in it for musl ? i can problably import the elogind musl_missing.h

@maxice8
Copy link
Contributor Author

maxice8 commented Apr 2, 2019

@the-maldridge ok to merge into the void

@maxice8 maxice8 closed this Apr 3, 2019
@maxice8 maxice8 deleted the systemd-boot branch April 3, 2019 13:35
@maxice8
Copy link
Contributor Author

maxice8 commented Apr 3, 2019

merged

@dkwo dkwo mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gottox Gottox Gottox left review comments

@Johnnynator Johnnynator Johnnynator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maxice8 @the-maldridge @Johnnynator @q66 @Gottox