New Package: Dwarf-Therapist v41.0.3 #10800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorporalCrawdad
force-pushed
the
Dwarf-Therapist
branch
from
0b2cd5d
to
822be43
Compare
maxice8
reviewed
Apr 11, 2019
|
Not an error, version cannot be higher, or at least needs to be lower. When dwarffortress updates this package will (almost certainly) need to update too. Breakage may happen if used with incompatible versions, is >= still desirable?
|
|
If that is the case then keep as is |
CorporalCrawdad
force-pushed
the
Dwarf-Therapist
branch
from
822be43
to
062c291
Compare
|
with dwarffortress merged this package should be ready for merging |
|
passing all travis checks, dependencies are satisfied, anything keeping from merge? |
Hoshpak
reviewed
Apr 30, 2019
| revision=1 | ||
| build_style=cmake | ||
| makedepends="qt5-declarative-devel libcap-devel hicolor-icon-theme" | ||
| depends="dwarffortress-0.44.12_2" |
There was a problem hiding this comment.
does it really have to depend on a specific version of the package? This will break when dwarffortress gets updated.
There was a problem hiding this comment.
A dwarffortress version update will almost certainly require a Dwarf Therapist update, but its not guaranteed, and it's unfortunate the revision can't be elided. Should the version dependency just be deleted and left to the sensibilities of the user?
|
I think it's better not to depend in a specific version at all or depend in a minimum version (>=) if that makes more sense in this case.
Am 2. Mai 2019 01:06:18 MESZ schrieb CorporalCrawdad <notifications@github.com>:
…CorporalCrawdad commented on this pull request.
> @@ -0,0 +1,17 @@
+# Template file for 'Dwarf-Therapist'
+pkgname=Dwarf-Therapist
+version=41.0.3
+revision=1
+build_style=cmake
+makedepends="qt5-declarative-devel libcap-devel hicolor-icon-theme"
+depends="dwarffortress-0.44.12_2"
A dwarffortress version update will almost certainly require a Dwarf
Therapist update, but its not guaranteed, and it's unfortunate the
revision can't be elided. Should the version dependency just be deleted
and left to the sensibilities of the user?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#10800 (comment)
|
|
Closing in favor of #22866. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary software to dwarffortress. Currently lists dwarffortress as a dependency because versions need to be compatible but Dwarf-Therapist does not link to dwarffortress in any way; if dwarffortress is not accepted as a package the dependency will need to be removed.