gcc: add patch to properly handle 64-bit long double for ppc*-musl #11466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Musl requires gcc to be built with 64-bit long doubles as it does not support the quad precision long double format, which is implemented in software using two doubles. This was already being patched, but it turns out libgcc is forcibly being built with 128-bit long doubles because of several glibc specific APIs it exposes. This wasn't causing any practical runtime issue, but it was causing problems when using e.g. the ld.gold linker to link, because it explicitly checks the ABI tag and libgcc was tagged as 128-bit long double. This extra patch solves the problem by conditionally compiling libgcc with 64-bit long doubles (only on musl) and disabling the APIs that would have been affected (as they are for glibc only). [ci skip]
pullmoll
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Musl requires gcc to be built with 64-bit long doubles as it does not support the quad precision long double format, which is implemented in software using two doubles.
This was already being patched, but it turns out libgcc is forcibly being built with 128-bit long doubles because of several glibc specific APIs it exposes. This wasn't causing any practical runtime issue, but it was causing problems when using e.g. the ld.gold linker to link, because it explicitly checks the ABI tag and libgcc was tagged as 128-bit long double.
This extra patch solves the problem by conditionally compiling libgcc with 64-bit long doubles (only on musl) and disabling the APIs that would have been affected (as they are for glibc only).