Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: disable telemetry #11517

Closed
wants to merge 1 commit into from
Closed

firefox: disable telemetry #11517

wants to merge 1 commit into from

Conversation

teldra
Copy link
Contributor

@teldra teldra commented May 5, 2019

No description provided.

@jnbr
Copy link
Contributor

jnbr commented May 5, 2019

Firefox is too big to be built by travis ci, I canceled the job.

According to the docs, MOZ_TELEMETRY_REPORTING must be defined to enable telemtry. We don't define it so it should be off already. In about:preferences#privacy
I see Data reporting is disabled for this build configuration.

Is there anything, besides the setting you changed, that makes you think telemetry is enabled in our builds?

@teldra
Copy link
Contributor Author

teldra commented May 5, 2019

toolkit.telemetry.enabled in about:config is true and locked.

@jnbr
Copy link
Contributor

jnbr commented May 5, 2019

I get that. But I have reasons to believe that this has no effect on our build (see my first answer). Hence the question:

Is there anything, besides the setting you changed, that makes you think telemetry is enabled in our builds?

@teldra
Copy link
Contributor Author

teldra commented May 5, 2019

No, besides the changed setting, there is nothing I think that it is enabled.

@teldra
Copy link
Contributor Author

teldra commented May 5, 2019

Err, this #11493

@Duncaen
Copy link
Member

Duncaen commented May 5, 2019

Telemetry is disabled and this config flag doesn't even disable it. It controls whether it sends extended telemetry (which is enabled only for pre-release channels if firefox is build with telemetry enabled).

https://bugzilla.mozilla.org/show_bug.cgi?id=1406391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants