Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passwordsafe: update to 1.08.1BETA #11854

Merged
merged 1 commit into from Jul 13, 2019
Merged

passwordsafe: update to 1.08.1BETA #11854

merged 1 commit into from Jul 13, 2019

Conversation

yopito
Copy link
Contributor

@yopito yopito commented May 21, 2019

No description provided.

@Johnnynator
Copy link
Member

@yopito The build is failing for i686 and armv7l

@yopito
Copy link
Contributor Author

yopito commented May 22, 2019

yep, have to fix it.

@yopito yopito changed the title passwordsafe: update to 1.08.1BETA [WIP] passwordsafe: update to 1.08.1BETA May 22, 2019
@yopito yopito mentioned this pull request Jul 4, 2019
Closed
@yopito
Copy link
Contributor Author

yopito commented Jul 5, 2019

fixed 32bit build but I'm not yet 100% confident about the corresponding patch.

@pullmoll
Copy link
Member

pullmoll commented Jul 5, 2019

@yopito You cannot test for a typedef <some_type> __time64_t; with #if !defined(__time64_t) because the typedef is not a macro. You could perhaps try to include <linux/time.h> and typedef __kernel_time64_t __time64_t; but I have no idea how to avoid a conflicting typedef.

@yopito
Copy link
Contributor Author

yopito commented Jul 5, 2019 •
edited

@pullmoll: I agree; in fact, __time64_t is both a typedef and a macro, and the macro is defined only on 64bit platform :(

Opened an issue's upstream upstream's issue: pwsafe/pwsafe#563

@yopito
Copy link
Contributor Author

yopito commented Jul 6, 2019

switched to upstream's patch. runtime tests are fine. Let's merge

@yopito yopito changed the title [WIP] passwordsafe: update to 1.08.1BETA passwordsafe: update to 1.08.1BETA Jul 6, 2019
@yopito yopito mentioned this pull request Jul 11, 2019
Closed
@pullmoll pullmoll merged commit 97048d3 into void-linux:master Jul 13, 2019
@yopito yopito deleted the passwordsafe.1.08.1 branch July 16, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yopito @Johnnynator @pullmoll