Linux5.1: Add some modules for laptops and tablets. #12102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I did that on purpose because last time I requested a minor change to the kernel, the maintainer didn't bump it. I figured it would be a waste to make everyone download a new kernel for a minor change like this and also occupy the builders. Should I always bump the revision in the future even if it is a minor change like this? Thanks. |
|
No, actually better not to revbump here. The kernel update rate is close to what our builders can manage anyway. I expect 5.1.7 within a week or so. |
Hoshpak
requested changes
Jun 4, 2019
There was a problem hiding this comment.
Please change the commit title. The package name should not be capitalized neither should the start of the comment. The additional comment does not need to be in the title, something like:
linux5.1: add some modules for laptops and tablets
The tc1100 is only a 32 bit device.
The tc1100 is only a 32 bit device.
Hoshpak
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.