Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mate-menus: update to 1.22.0. #12170

Merged
merged 1 commit into from
Jun 6, 2019
Merged

mate-menus: update to 1.22.0. #12170

merged 1 commit into from
Jun 6, 2019

Conversation

thomas-t-w
Copy link
Contributor

The soname didn't actually bump numerically, however, packages say they require the new version. Let me know if this is the correct procedure.

@thomas-t-w
Copy link
Contributor Author

Backing out the change to shlibs. I am realizing that this won't do anything for me since there wasn't a soname bump based on comments in issue 12165 and some research of my own. correct me if I am wrong here please.

@Hoshpak
Copy link
Member

Hoshpak commented Jun 6, 2019

You're right. Configure scripts usually detect version of dependencies by querying pkg-config, cmake files or some other mechanism, not by soname. If a package needs a new version of a dependency, it's best to put both of them in a PR together, that way the build system will build the dependency first, then the package and you will know whether it works or not.

Alternatively, you can wait for the dependency to be merged and then rebase the PR that needs the newer version on top of master to make it pass travis.

@Hoshpak Hoshpak merged commit b0f5b02 into void-linux:master Jun 6, 2019
@thomas-t-w thomas-t-w deleted the menus branch June 7, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants