Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: oilshell-0.6.0 #12891

Merged
merged 1 commit into from Jul 9, 2019
Merged

New package: oilshell-0.6.0 #12891

merged 1 commit into from Jul 9, 2019

Conversation

Wychmire
Copy link
Contributor

@Wychmire Wychmire commented Jul 7, 2019

Closes #12835

@Wychmire Wychmire mentioned this pull request Jul 7, 2019
Closed
Hoshpak
Hoshpak reviewed Jul 9, 2019
View reviewed changes
srcpkgs/oilshell/template Outdated Show resolved Hide resolved
Hoshpak
Hoshpak reviewed Jul 9, 2019
View reviewed changes
srcpkgs/oilshell/template Outdated Show resolved Hide resolved
Hoshpak
Hoshpak reviewed Jul 9, 2019
View reviewed changes
Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the package called oilshell and not just oil? We usually keep the upstream names for packages and since neither the tarball nor the binary are called oilshell it seems strange to me to rename it like that.

@Wychmire
Copy link
Contributor Author

Wychmire commented Jul 9, 2019

I never really thought about it. The website is called oilshell.org, and since the the program is a shell I guess I figured that it was called oilshell. The aur package is also called oilshell.
Fair point though. If I'm going to rename the pakage oil, would I have to create a new PR or just rename the commit?

@abenson
Copy link
Contributor

abenson commented Jul 9, 2019

Rename the template directory and the pkgname in the template, then update the commit to reflect. Keep it all in this PR.

@Wychmire
New package: oil-0.6.0
d778c5e 
re-add nostrip


Add proper readline build option and re-add nocross


make using the readline option default and remove desc


fix readline option


fix nocross reason


remove nostrip=yes and the removal of the wrapper in do_install


rename oilshell to oil


re-add nostrip
@Wychmire
Copy link
Contributor Author

Wychmire commented Jul 9, 2019

Everything should be renamed properly now.

@Hoshpak Hoshpak merged commit b9175a4 into void-linux:master Jul 9, 2019
@Wychmire Wychmire deleted the oilshell branch July 10, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johnnynator Johnnynator Johnnynator left review comments

@Hoshpak Hoshpak Hoshpak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package Request: Oilshell
4 participants
@Wychmire @abenson @Johnnynator @Hoshpak