Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcomix: fix python-pillow-6.0.0 compatibility #13148

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

seisatsu
Copy link
Contributor

Fixes the incompatibility issue between MComix and Python-Pillow-6.0.0 described in issue #13143 using patches found at https://github.com/mat813/freebsd-ports/tree/d9a5e385afb3dab755ebe5138b09cf7351f992d9/graphics/py-mcomix/files

@seisatsu
Copy link
Contributor Author

seisatsu commented Jul 16, 2019

Give me a moment, I may have screwed something up. Double checking. It's my first time doing this.

@seisatsu
Copy link
Contributor Author

seisatsu commented Jul 16, 2019

Everything's tested and works, but the package version needs to be bumped from mcomix-1.2.1_1 to mcomix-1.2.1_2 in the template, which I forgot to do. Looking at other pull requests I think I also didn't follow the naming convention for my commit. Let me know if I should make a new pull request of if it can be fixed up on your end.

Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the revision and fix the commit title. There's no need to open a new PR. You can just amend your commit (make the changes, git add, git commit --amend) and force-push (git push -f) to your own branch to update it.

@seisatsu seisatsu changed the title Fix #13143 by patching MComix for PIL-6.0.0 compat. mcomix: fix python-pillow-6.0.0 compatibility Jul 16, 2019
@seisatsu
Copy link
Contributor Author

There, that should do it.

@Hoshpak Hoshpak merged commit 4cc8a51 into void-linux:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants