Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce4-panel: split lib #13979

Closed
wants to merge 33 commits into from
Closed

Conversation

Piraty
Copy link
Member

@Piraty Piraty commented Aug 26, 2019

No description provided.

@q66
Copy link
Contributor

q66 commented Aug 26, 2019

Any reason for this?

@Piraty
Copy link
Member Author

Piraty commented Aug 29, 2019

I don't remember the details anymore tbh, but once i was annoyed by something that required the only lib but pulled the hole xfce4-panel package along irrelevant (at least to me) dependencies.

@q66
Copy link
Contributor

q66 commented Aug 29, 2019

I'm pretty curious what that thing was... only panel widgets should really depend on the panel lib, and those make sense to pull in the panel too.

@Piraty
Copy link
Member Author

Piraty commented Aug 30, 2019

You're probably right. Putting this PR to sleep until i can come up with more information

@Piraty
Copy link
Member Author

Piraty commented Oct 17, 2019

I opened and rebased. Builds for x86_64
@pbui @q66 @Hoshpak

@Hoshpak
Copy link
Member

Hoshpak commented Oct 17, 2019

lgtm

1 similar comment
@pbui
Copy link
Contributor

pbui commented Oct 18, 2019

lgtm

@Piraty Piraty closed this in 44ce196 Oct 18, 2019
@Piraty Piraty deleted the xfce4-panel-split-lib branch October 19, 2019 19:18
bilebucket pushed a commit to bilebucket/void-packages that referenced this pull request Oct 22, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants