Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New package: corosync-3.0.2 #14061

Closed
wants to merge 1 commit into from
Closed

[WIP] New package: corosync-3.0.2 #14061

wants to merge 1 commit into from

Conversation

jirib
Copy link
Contributor

@jirib jirib commented Aug 30, 2019

The Corosync Cluster Engine is a Group Communication System with additional features for implementing high availability within applications.

Needed for future pacemaker package.

@jirib
Copy link
Contributor Author

jirib commented Aug 30, 2019

Any idea about following issue?

$ xbps-query -l | grep corosynclib
ii corosynclib-3.0.2_1                     Corosync libraries
$ sudo xbps-install --repository=hostdir/binpkgs/corosync/ corosynclib-devel
MISSING: corosynclib=>3.0.2_1
Transaction aborted due to unresolved dependencies.

@jirib jirib marked this pull request as ready for review August 30, 2019 00:53
@Hoshpak
Copy link
Member

Hoshpak commented Aug 30, 2019

=> looks odd, I think it should be >=. However you should not need to add that manually since dependencies on shard libraries are automatically detected by xbps-src while building the package. Following the usual pattern for libraries, the sub-package should be called `libcorosync'. Haven't reviewed the rest of the template yet.

@jirib
Copy link
Contributor Author

jirib commented Sep 1, 2019

=> looks odd, I think it should be >=. However you should not need to add that manually since dependencies on shard libraries are automatically detected by xbps-src while building the package. Following the usual pattern for libraries, the sub-package should be called `libcorosync'. Haven't reviewed the rest of the template yet.

Thanks, it was this typo.

BTW, as libknet1 does not build on musl archs, how should this package be treated? Should I define it to be only for non-musl archs? IIUC corosync can't be easily told to be build without 'knet' transport now, see corosync/corosync#501

@jirib
Copy link
Contributor Author

jirib commented Sep 5, 2019

=> looks odd, I think it should be >=. However you should not need to add that manually since dependencies on shard libraries are automatically detected by xbps-src while building the package. Following the usual pattern for libraries, the sub-package should be called `libcorosync'. Haven't reviewed the rest of the template yet.

Thanks, it was this typo.

BTW, as libknet1 does not build on musl archs, how should this package be treated? Should I define it to be only for non-musl archs? IIUC corosync can't be easily told to be build without 'knet' transport now, see corosync/corosync#501

Solved, I'm preparing libknet1/libnozzle1 (new subpkg) fix which would support musl, #14215

@jirib jirib closed this Sep 5, 2019
@jirib jirib deleted the corosync branch September 5, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants