-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox esr #14229
firefox esr #14229
Conversation
You can put script into files/ . |
Could you also test building for i686 and at least one supported cross architecture? These things tend to fail a lot so I would like to have it tested before merging. |
On September 8, 2019 9:02:33 AM UTC, Helmut Pozimski ***@***.***> wrote:
Could you also test building for i686 and at least one supported cross
architecture? These thinks tend to fail a lot so I would like to have
it tested before merging.
I'll try to build for i686, ppc and arch64.
It would take time since my build machine is not very fast.
--
Danh
|
[skip ci] Signed-off-by: Doan Tran Cong Danh <congdanhqx@gmail.com>
@@ -0,0 +1,81 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think updates scripts like this should be in the void-packages repo, xtools would be more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, I intended to add it into xtools.
However, this script is only useful for firefox and firefox-esr,
and @Chocimier told it's better to include it here.
Anyway, it's in separated commit, I'll drop it out of void-packages tree
if we can gain the consensus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reason to include it here is that it is tied to one package, so
- easier to find
- xtools is useful for non-maintainers - we ask for xuname output for bug reports - and populating /bin with package-tied scripts for them isn't great
- we have similar scripts for bash, iana-etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Chocimier , having such scripts in the tree is highly useful. I've used the glibc update script in the past to update upstream patches which is also in tree.
Testing is stuck because of update on gcc and cross toolchain, hence xbps-src want to rebuild a lot of packages. |
This PR could be pulled for now.
|
Built for:
but it's reset to Google on the second restart, the default search engine in setting,
and search bar. and in homepage doesn't survive the restart.
Reproducible with Firefox 69.0
tool-chain crashedI forget to remove-march=native
in my configuration