Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox esr #14229

Merged
merged 3 commits into from
Sep 15, 2019
Merged

firefox esr #14229

merged 3 commits into from
Sep 15, 2019

Conversation

sgn
Copy link
Member

@sgn sgn commented Sep 6, 2019

Built for:

  • x86_64 from x86_64 bootstrap - TESTED
  • x86_64-musl from x86_64-musl bootstrap - TESTED
  • i686 from i686 bootstrap - BUILT and smoke TESTED.
    • Setting search engine seems broken, the search engine in address bar survives one restart,
      but it's reset to Google on the second restart, the default search engine in setting,
      and search bar. and in homepage doesn't survive the restart.
      Reproducible with Firefox 69.0
    • add-on works fine
  • i686 from x86_64 bootstrap - IN PROGRESS
  • aarch64-musl from x86_64-musl bootstrap - smoke TESTED
  • ppc64le-musl from x86_64-musl bootstrap

@Chocimier
Copy link
Member

You can put script into files/ .

@Hoshpak
Copy link
Member

Hoshpak commented Sep 8, 2019

Could you also test building for i686 and at least one supported cross architecture? These things tend to fail a lot so I would like to have it tested before merging.

@sgn
Copy link
Member Author

sgn commented Sep 8, 2019 via email

[skip ci]

Signed-off-by: Doan Tran Cong Danh <congdanhqx@gmail.com>
@sgn sgn changed the title Firefox esr [wip] firefox esr Sep 8, 2019
@@ -0,0 +1,81 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think updates scripts like this should be in the void-packages repo, xtools would be more appropriate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally, I intended to add it into xtools.
However, this script is only useful for firefox and firefox-esr,
and @Chocimier told it's better to include it here.

Anyway, it's in separated commit, I'll drop it out of void-packages tree
if we can gain the consensus.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reason to include it here is that it is tied to one package, so

  • easier to find
  • xtools is useful for non-maintainers - we ask for xuname output for bug reports - and populating /bin with package-tied scripts for them isn't great
  • we have similar scripts for bash, iana-etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Chocimier , having such scripts in the tree is highly useful. I've used the glibc update script in the past to update upstream patches which is also in tree.

@sgn
Copy link
Member Author

sgn commented Sep 9, 2019

Testing is stuck because of update on gcc and cross toolchain, hence xbps-src want to rebuild a lot of packages.
I'll get back to work on this pr when void buildbot settled.

@sgn sgn changed the title [wip] firefox esr firefox esr Sep 15, 2019
@sgn
Copy link
Member Author

sgn commented Sep 15, 2019

This PR could be pulled for now.
There're 2 issues:

  • Cross compile i686 from x86_64 depends on cross-i686 compiler: keep sysroot /lib symlink #14401 but most people compile i686 from i686 bootstrap
  • cross compile ppc64le from x86_64 have some problems with cross-compiler tool-chain, but running xbps-src again can build it successfully. I'm gonna investigate xbps

@Hoshpak Hoshpak merged commit f373259 into void-linux:master Sep 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants