Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkit2gtk: update to 2.26.0 #14366

Merged
merged 1 commit into from
Sep 11, 2019
Merged

webkit2gtk: update to 2.26.0 #14366

merged 1 commit into from
Sep 11, 2019

Conversation

q66
Copy link
Contributor

@q66 q66 commented Sep 9, 2019

The new stable webkit2gtk series was released today, sooner than expected.

Needed building and testing:

  • ppc64le*
  • ppc64*
  • ppc*
  • x86_64
  • x86_64-musl
  • aarch64 (build)
  • armv7l (build)

I particularly need someone to test the x86_64 stuff again, and especially musl. 32-bit ARM builds would be nice too, I don't have any way to do them from there. I can test building aarch64, though

This reenables the bubblewrap sandbox as was in the 2.25.x update.

[ci skip]
@Hoshpak
Copy link
Member

Hoshpak commented Sep 10, 2019

x86_64 builds and runs fine. x86_64-musl and armv7l compile successfully.

@q66
Copy link
Contributor Author

q66 commented Sep 10, 2019

Alright. Just need someone to actually test on musl then... if you've got a binary package somewhere, I can test that myself

@Hoshpak
Copy link
Member

Hoshpak commented Sep 10, 2019

@q66
Copy link
Contributor Author

q66 commented Sep 10, 2019

Well, appears to be OK in my VM... better testing in a native environment would be good though.

@q66
Copy link
Contributor Author

q66 commented Sep 10, 2019

Seems like YouTube/video playback doesn't work on x86_64-musl with 2.26 (it works just fine on non-musl), at least in my VM (in 2.24 it works). I think the problem is not in webkit itself though, i think it has something to do with gstreamer (it seems to use playbin3 now, and i got some assertion failures from that). No way to fix this from my side though...

@q66
Copy link
Contributor Author

q66 commented Sep 10, 2019

My findings mostly show that gstreamer is indeed at fault here, more specifically the audio stream. I can seek in the video when paused, but when I try to play it out, it dies; it it dies on not being able play out a stream, completely on the gstreamer side...

So I kinda assume the problem is actually not webkit here... I even managed to get it to play the video for about a second, under some circumstances, before gst aborts the playback.

@q66
Copy link
Contributor Author

q66 commented Sep 10, 2019

Alright. Turns out my suspicion was right, and video playback works on machines with working audio. Most likely gstreamer craps out at getting access to audio device in my VM, which 2.24 ignored but 2.26 no longer ignores (probably because it uses a different gstreamer player abstraction, playbin3, for MSE sources like youtube). Testing by another person with a functional audio setup reveals that youtube playback is in fact completely fine.

Therefore, there are no more blockers from my side.

@Johnnynator
Copy link
Member

I can't currently help much with that, gstreamer behaves totally borked on my system. But judging by your comment, the issue should be unrelated to Musl and is probably fine.

@Hoshpak Hoshpak merged commit 38120ec into void-linux:master Sep 11, 2019
@q66 q66 deleted the webkit226 branch October 19, 2019 18:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants