-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webkit2gtk: update to 2.26.0 #14366
webkit2gtk: update to 2.26.0 #14366
Conversation
This reenables the bubblewrap sandbox as was in the 2.25.x update. [ci skip]
x86_64 builds and runs fine. x86_64-musl and armv7l compile successfully. |
Alright. Just need someone to actually test on musl then... if you've got a binary package somewhere, I can test that myself |
Sure, the package is here: |
Well, appears to be OK in my VM... better testing in a native environment would be good though. |
Seems like YouTube/video playback doesn't work on |
My findings mostly show that gstreamer is indeed at fault here, more specifically the audio stream. I can seek in the video when paused, but when I try to play it out, it dies; it it dies on not being able play out a stream, completely on the gstreamer side... So I kinda assume the problem is actually not webkit here... I even managed to get it to play the video for about a second, under some circumstances, before gst aborts the playback. |
Alright. Turns out my suspicion was right, and video playback works on machines with working audio. Most likely gstreamer craps out at getting access to audio device in my VM, which 2.24 ignored but 2.26 no longer ignores (probably because it uses a different gstreamer player abstraction, playbin3, for MSE sources like youtube). Testing by another person with a functional audio setup reveals that youtube playback is in fact completely fine. Therefore, there are no more blockers from my side. |
I can't currently help much with that, gstreamer behaves totally borked on my system. But judging by your comment, the issue should be unrelated to Musl and is probably fine. |
The new stable webkit2gtk series was released today, sooner than expected.
Needed building and testing:
I particularly need someone to test the x86_64 stuff again, and especially musl. 32-bit ARM builds would be nice too, I don't have any way to do them from there. I can test building aarch64, though