Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dosbox: patch to support full mapping of joysticks #14474

Closed

Conversation

joshuakraemer
Copy link
Contributor

@joshuakraemer joshuakraemer commented Sep 15, 2019

Without this patch, dosbox is only able to use:

  • either 2 joysticks/gamepads with 1 analog stick each (no hat switches/d-pads)
  • or 1 joystick/gamepad with 1 analog stick and 1 hat switch/d-pad (with joysticktype=fcs)

This patch allows full mapping of 2 joysticks/gamepads with 2 analog sticks and 1 hat switch/d-pad, which means modern joysticks and gamepads can be fully used to play dos games in 2-player mode.

This patch is also used by Recalbox OS, see https://github.com/recalbox/recalbox-buildroot/blob/master/package/dosbox/dosbox-003-joystick-8axis.patch

@Hoshpak
Copy link
Member

Hoshpak commented Sep 16, 2019

What is the upstream status of this patch? We usually only patch to make packages work or fix issues, not to enhance functionality.

@joshuakraemer
Copy link
Contributor Author

I have filed a feature request to reconsider the patch upstream, which was already suggested in 2011: https://sourceforge.net/p/dosbox/feature-requests/137/

@ericonr
Copy link
Member

ericonr commented May 6, 2020

@joshuakraemer are you following dosbox-staging? We could package that, instead.

@abenson
Copy link
Contributor

abenson commented May 7, 2020

@joshuakraemer are you following dosbox-staging? We could package that, instead.

I have a dosbox-staging template but I'm not sure if it would be wanted

@pullmoll
Copy link
Member

pullmoll commented May 7, 2020

IMO we should stay with stable releases and, if absolutely necessary, backport patches. I believe this is the consesus for Void packages in general.

@abenson
Copy link
Contributor

abenson commented May 7, 2020

dosbox-staging is a fork

@pullmoll
Copy link
Member

pullmoll commented May 7, 2020

Uh, ok, that's a different story.

@joshuakraemer
Copy link
Contributor Author

joshuakraemer commented May 9, 2020

Thank you @ericonr and @abenson, I did not know about dosbox-staging. I have already thought about packaging dosbox-ece (template here: joshuakraemer@c926d79), but I think dosbox-staging is the better choice. I would second packaging it.

While it does not solve the original issue (full mapping of controllers), the team seems to be more open to community suggestions, so I will file an issue with them.

Edit: dosbox-staging issue: dosbox-staging/dosbox-staging#342

@ericonr
Copy link
Member

ericonr commented Jul 16, 2021

Superseded by #31258

@ericonr ericonr closed this Jul 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants