Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlc: add chromecast option #15022

Merged
merged 1 commit into from Oct 4, 2019

Conversation

Stantheman
Copy link
Contributor

Hi, this is adding an option to build VLC with support for chromecasting

@Hoshpak Hoshpak self-assigned this Oct 4, 2019
Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution to Void! Please review my comments and amend the commit.

srcpkgs/vlc/template Outdated Show resolved Hide resolved
srcpkgs/vlc/template Show resolved Hide resolved
@Stantheman
Copy link
Contributor Author

Thank you for the very helpful and detailed review @Hoshpak! It was really helpful as a newcomer to xbps. I've pushed up the changes and are waiting for tests to finish up. Please let me know if anything else needs changing. I've tested for a while now locally and followed the guidelines in the contribution document to try to reduce any additional burden

@Hoshpak
Copy link
Member

Hoshpak commented Oct 4, 2019

There's just one more thing I forgot to mention earlier. Since the build option is now the default, the resulting binary package will be different than the one currently in the repository. The builders will only rebuild a package if the version or revision of the template is different than the one currently in the repository so please increment the revision number in the template.

Adds default build option for rendering to chromecast
@Hoshpak Hoshpak merged commit 2ef4456 into void-linux:master Oct 4, 2019
@Stantheman
Copy link
Contributor Author

Awesome, thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants