vala-panel-appmenu: fix dependency typo #15301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoshpak
requested changes
Oct 11, 2019
There was a problem hiding this comment.
Thanks for your first contribution to Void. The convention on commit titles for changing exisiting templates is pkgname: message. So please change the commit title to something along the lines of
vala-panel-appmenu: fix dependency typo
and squash the commits into on before force-pushing again.
usrfriendly
changed the title
|
@Hoshpak are these changes acceptable? I've never done a squash before, and this is my first PR. Thanks for the feedback, I should've taken my time with this the first time. |
|
The squash is fine however with the commit title I meant the title of the actual commit in git and not the PR on github. Please change that and then this can be merged. |
|
Got it, sorry about that, should be fixed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a typo in the dependencies for the appmenu-gtk-module-devel package where a dependency was listed as "appmenu-gkt3-module" and am submitting a correction for it so the package may actually be installable.