Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: dlib-19.18 #15512

Closed
wants to merge 1 commit into from
Closed

New package: dlib-19.18 #15512

wants to merge 1 commit into from

Conversation

felix
Copy link
Contributor

@felix felix commented Oct 16, 2019

No description provided.

@Piraty
Copy link
Member

Piraty commented Oct 19, 2019

hi,

  • please squash your commits
  • please use an order of variables that is consistent with other templates

@q66
Copy link
Contributor

q66 commented Oct 19, 2019 •
edited
Loading

also protip: use rebase instead of merge when updating your branch

for consistent order of variables, use xlint on the template file (xbps-install xtools). In your case it should fail but it doesn't because of the spurious newline after checksum, so remove that one too.

Piraty
Piraty reviewed Oct 19, 2019
View reviewed changes
srcpkgs/dlib/template Outdated
Comment on lines 13 to 18
makedepends="$(vopt_if openblas openblas-devel) $(vopt_if x11 libX11-devel)"
build_options="openblas x11"
desc_option_openblas="Enable OpenBlas for performance"
desc_option_x11="Enable X11 for GUI components"
build_options_default="openblas x11"
configure_args=Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move configure_args and makedepends (in that order) below build_style

@felix felix force-pushed the dlib branch 2 times, most recently from ce62ea4 to 7612ccd Compare October 21, 2019 09:49
@felix
Copy link
Contributor Author

felix commented Oct 21, 2019

Thanks, I have not use void for a while so am a bit rusty. xlint does not seem to pick up the style errors mentioned above either.

@Piraty
Copy link
Member

Piraty commented Oct 21, 2019 •
edited
Loading

yes, we noticed xlint's fail as well.
@felix you got some other commit squashed along as well, please cleanup

Piraty pushed a commit to Piraty/void-packages that referenced this pull request Jun 17, 2020
@felix @Piraty
New package: dlib-19.18
e9ff2a4 
Closes: void-linux#15512 [via git-merge-pr]
Piraty
Piraty requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@Piraty Piraty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make it use sytem libraries if possible, instead of bundled ones in dlib/external/

Piraty
Piraty requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@Piraty Piraty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's more: in order to be useful in a linux distribution, you should build the shared libraries as well, and split the package into lib and -devel.
Do you expect packaged software to use this some day?

srcpkgs/dlib/template
version=19.18
revision=1
build_style=cmake
configure_args=Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not doing anything useful. see here

Piraty added a commit to Piraty/void-packages that referenced this pull request Jun 17, 2020
@Piraty
New package: dlib-19.20
ba244b0 
Closes: void-linux#15512
@Piraty Piraty mentioned this pull request Jun 17, 2020
Merged
@Piraty
Copy link
Member

Piraty commented Jun 17, 2020

I hope you don't mind i propose a modified version in #23007.

Piraty added a commit that referenced this pull request Jun 21, 2020
@Piraty
New package: dlib-19.20
3b42d1c 
Closes: #15512
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Piraty Piraty Piraty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felix @Piraty @q66