New package: jetbrains-jdk-bin-11.0.5b569.2 #15629
Conversation
2asoft
force-pushed
the
2asoft/jetbrains-jre
branch
2 times, most recently
from
7cad3a0
to
e02d4f0
Compare
There was a problem hiding this comment.
Good to see you back.
For providing multiple versions they must be packaged under different names. But is it needed for this package? In case of future need, we can do like with other libraries and make version-suffixed package for older one until dependants catch up.
This package could provide java-environment and alternatives for java, but not before we have openjdk updated to 11.
srcpkgs/jetbrains-jdk-11/template
Outdated
| _jdk_fullver="11.0.4" | ||
| _archive_name="jbrsdk-${_jdk_fullver//\./_}-linux-x64-b${_jdk_build}.tar.gz" | ||
|
|
||
| pkgname=jetbrains-jdk-11 |
There was a problem hiding this comment.
Should have -bin suffix, because it is repacked binaries. This requirement will not apply to IDEs, as they are restricted.
srcpkgs/jetbrains-jdk-11/template
Outdated
| _archive_name="jbrsdk-${_jdk_fullver//\./_}-linux-x64-b${_jdk_build}.tar.gz" | ||
|
|
||
| pkgname=jetbrains-jdk-11 | ||
| version="${_jdk_fullver}b${_jdk_build}" |
There was a problem hiding this comment.
Better to do opposite, derive _jdk* from version, see libcli.
srcpkgs/jetbrains-jdk-11/template
Outdated
| hostmakedepends="aria2" | ||
| short_desc="JetBrains Java 11 JDK" | ||
| maintainer="Anton Afanasyev <anton@doubleasoftware.com>" | ||
| license="GPL-2.0+CE" |
There was a problem hiding this comment.
GPL-2.0-only, Classpath-exception-2.0
srcpkgs/jetbrains-jdk-11/template
Outdated
| # Best guess is that they are optional. ¯\_(ツ)_/¯ | ||
| noverifyrdeps=yes | ||
|
|
||
| fetch_cmd="aria2c -c" |
There was a problem hiding this comment.
At least this works, what is good. Please use wget, as more widespread. Tried setting useragent and referer, but still don't work with xbps-uhelper.
There was a problem hiding this comment.
There are some redirects there that wget doesnt seem to follow correctly, while aria2 does.
Since this is only for the build machines (right?), is it a big issue that aria2 is left as the fetch command?
There was a problem hiding this comment.
This seems to work with wget for me now, so switched to it.
srcpkgs/jetbrains-jdk-11/update
Outdated
| @@ -0,0 +1,3 @@ | |||
| version=b${version#*b} | |||
| pattern="jbrsdk-\d+_\d+_\d+-(?:linux-x64-)\Kb\d+\.\d+(?=\.tar\.gz</a>)" | |||
| site="https://bintray.com/package/files/jetbrains/intellij-jbr/jbrsdk11-linux-x64" | |||
There was a problem hiding this comment.
Don't work for me, but right pattern with default site works.
There was a problem hiding this comment.
Agreed, default site works, will change
srcpkgs/jetbrains-jdk-11/template
Outdated
|
|
||
| _jdk_build=520.2 | ||
| _jdk_fullver="11.0.4" | ||
| _archive_name="jbrsdk-${_jdk_fullver//\./_}-linux-x64-b${_jdk_build}.tar.gz" |
2asoft
force-pushed
the
2asoft/jetbrains-jre
branch
from
e02d4f0
to
7b13476
Compare
2asoft
changed the title
2asoft
force-pushed
the
2asoft/jetbrains-jre
branch
2 times, most recently
from
8ac0d8e
to
949f384
Compare
2asoft
changed the title
|
@Chocimier I believe I've addressed all comments now. |
|
Works with pycharm, looks ok. But, as said, I rather not want have version in pkgname before there is need to have more than one version. And please remove empty lines in variables section. |
2asoft
force-pushed
the
2asoft/jetbrains-jre
branch
from
949f384
to
61c9a11
Compare
2asoft
changed the title
|
I must've missed the part about empty lines, and didn't understand that I should remove the version number. |
2asoft
force-pushed
the
2asoft/jetbrains-jre
branch
3 times, most recently
from
780a480
to
1dc0928
Compare
2asoft
changed the title
2asoft
force-pushed
the
2asoft/jetbrains-jre
branch
from
1dc0928
to
19b2b74
Compare
|
Friendly ping. |
Package name is
jetbrains-jdk-11.Version is
11.0.4 build 520.2.The
-11is part of package name because there is also a JDK 8 by JetBrains.If there is a way to publish multiple disjoint versions of a package by the same name, (eg a jetbrains-jdk v8 and a v11), I would appreciate a pointer so I could change the template here.
The sources for this are available at the "homepage" location.
Ideally, we should build the sources to JetBrainsd JDK, however, I do not currently have the time to setup that build.
There is such a package in AUR in Arch Linux, it could be used as an example.
Once this is merged, I will also update PR #11736 to depend on this jdk.