Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-visualiser: update to 4.0 #15804

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

newbluemoon
Copy link
Contributor

No description provided.

@newbluemoon
Copy link
Contributor Author

newbluemoon commented Oct 26, 2019

Cross-builds only seem to find the qt5 host libraries now so as a quick workaround until something better comes up I just inserted the cross base via sed into the qmake-generated makefiles.

And because the libevent update doesn’t seem to have made it to most cross targets, yet (except for armv6l-musl) I think it’d be better to wait for them to catch up and test this before merging.

@newbluemoon
Copy link
Contributor Author

The problem with sonic-visualiser is that it is a mixed build-style: gnu-configure runs qmake in the end so that in cross cases qmake isn’t set up properly. To work-around this I just copied the creation of the qt.conf file from the qmake build-style and made qmake use it.

The xlint error is because of creating the custom qt.conf. Everything else is fine now. Tested on x86_64, x86_64-musl, and armv7l-musl (RPi).

But I think there are some other templates which are mixed qmake build-styles. Would it make sense to create a qmake-cross-wrapper (but only when the build-style is not qmake) which sets up and uses a qt.conf file?

@Hoshpak
Copy link
Member

Hoshpak commented Oct 29, 2019

I just stumbled upon the same issue with smplayer which uses a makefile to call qmake so I think it would be beneficial to have a build_helper or similar for that case.

@Hoshpak Hoshpak merged commit 9ef0322 into void-linux:master Oct 29, 2019
@newbluemoon newbluemoon deleted the sonic-visualiser branch November 4, 2019 18:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants