Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: awesome-LuaJIT #16137

Closed
wants to merge 2 commits into from
Closed

New Package: awesome-LuaJIT #16137

wants to merge 2 commits into from

Conversation

mustaqimM
Copy link
Contributor

This seems to work fine as I'm currently using it:

$ awesome -v
awesome v4.3 (Too long)
 • Compiled against Lua 5.1.5 (running with LuaJIT 2.1.0-beta3)
 • D-Bus support: ✔
 • execinfo support: ✔
 • xcb-randr version: 1.6
 • LGI version: 0.9.2

@mustaqimM mustaqimM changed the title Awesome luajit New Package: awesome-LuaJIT Nov 5, 2019
@Piraty
Copy link
Member

Piraty commented Nov 10, 2019

I think it makes more sense to extend the existing awesome template and make this a build_option, instead of adding another template.

@ndgnuh
Copy link
Contributor

ndgnuh commented Mar 9, 2020

I don't think lgi-luaJIT is conflicted with lgi, since both use different version of lua and have different directory structure, except for the /usr/bin/dump-typelib, which is a .lua file, which can be renamed to dump-typelib-luajit or something like that

$ xbps-query --list-pkgs | grep lgi
ii lgi-0.9.2_2                            Lua binadings for gnome/gobject using gobject-introspection library
ii lgi-LuaJIT-0.9.2_1                     LuaJIT bindings for gnome/gobject using gobject-introspection library
.

@@ -0,0 +1,23 @@
# Template file for 'lgi-LuaJIT'
pkgname=lgi-LuaJIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this package actually doesn't have anything to do with LuaJIT. Both LuaJIT and lua51 can use what ever contained in that package. So I suggest changing the name to lua51-lgi.

Copy link
Contributor

@q66 q66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a build option at most, luajit is more or less dead and i don't think it's wise to add packages duplicating stuff for no good reason with questionable benefit

@q66
Copy link
Contributor

q66 commented Mar 29, 2020

oh, it's an old PR. If nobody is interested in doing anything to this, we can close it

Comment on lines +18 to +21
conflicts="lgi"

post_install() {
vbin tools/dump-typelib.lua dump-typelib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, I inspected the original lgi and this package. The only file that is conflict is the tools/dump-typelib.lua. Maybe we should change this to dump-tpyelib5.1, the one in the original lgi to dump-typelib5.3 and add and alternative group?

@ndgnuh
Copy link
Contributor

ndgnuh commented Mar 29, 2020

I'm working on a build option with awesome, but that will require some changes on lgi too. I'll send a PR soon.

Edit: After making sure that it builds nicely on some other archs of course.

@hippi777
Copy link

hi folks! :)

@q66, luajit is alive, there was no sign about Mike (its main developer) for something like a year, and he announced before that, that he has other duties, but some months ago he reappeared and started to work on luajit again. in the meantime, moonjit appeared, and its main purpose is to be a drop in replacement for luajit, and basically it collects the pending pull requests for luajit and makes releases more often. (< in case of interest...) however luajit is actually under development now, just no fresh release came out for a long while.

btw i dunno why its written formally, as LuaJIT, instead of luajit in the package name, but im a new kid here... :D

otherwise +1 for a build option instead, but ive got no interest in this...

bests! :)

@ndgnuh
Copy link
Contributor

ndgnuh commented Mar 29, 2020

Hello, I've opened another PR #20443. Can anyone review please? Thank you.

@q66
Copy link
Contributor

q66 commented Mar 29, 2020

@hippi777 having a fair amount of experience with LuaJIT, I don't see it as entirely sustainable considering the code is rather unorthodox and barely maintainable for anybody who isn't Mike, and Mike being around or not being around makes a bus factor of 1, so I'm wary of this either way. While moonjit might be a thing now, that's pretty much just a dumping grounds for unmerged LuaJIT pull requests, which is hardly an ideal solution in itself.

Anyway, closing this.

@q66 q66 closed this Mar 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants