New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Package: awesome-LuaJIT #16137
New Package: awesome-LuaJIT #16137
Conversation
I think it makes more sense to extend the existing awesome template and make this a build_option, instead of adding another template. |
I don't think
|
@@ -0,0 +1,23 @@ | |||
# Template file for 'lgi-LuaJIT' | |||
pkgname=lgi-LuaJIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this package actually doesn't have anything to do with LuaJIT
. Both LuaJIT
and lua51
can use what ever contained in that package. So I suggest changing the name to lua51-lgi
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a build option at most, luajit is more or less dead and i don't think it's wise to add packages duplicating stuff for no good reason with questionable benefit
oh, it's an old PR. If nobody is interested in doing anything to this, we can close it |
conflicts="lgi" | ||
|
||
post_install() { | ||
vbin tools/dump-typelib.lua dump-typelib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one, I inspected the original lgi
and this package. The only file that is conflict is the tools/dump-typelib.lua
. Maybe we should change this to dump-tpyelib5.1
, the one in the original lgi
to dump-typelib5.3
and add and alternative group?
I'm working on a build option with awesome, but that will require some changes on lgi too. I'll send a PR soon. Edit: After making sure that it builds nicely on some other archs of course. |
hi folks! :) @q66, luajit is alive, there was no sign about Mike (its main developer) for something like a year, and he announced before that, that he has other duties, but some months ago he reappeared and started to work on luajit again. in the meantime, moonjit appeared, and its main purpose is to be a drop in replacement for luajit, and basically it collects the pending pull requests for luajit and makes releases more often. (< in case of interest...) however luajit is actually under development now, just no fresh release came out for a long while. btw i dunno why its written formally, as LuaJIT, instead of luajit in the package name, but im a new kid here... :D otherwise +1 for a build option instead, but ive got no interest in this... bests! :) |
Hello, I've opened another PR #20443. Can anyone review please? Thank you. |
@hippi777 having a fair amount of experience with LuaJIT, I don't see it as entirely sustainable considering the code is rather unorthodox and barely maintainable for anybody who isn't Mike, and Mike being around or not being around makes a bus factor of 1, so I'm wary of this either way. While moonjit might be a thing now, that's pretty much just a dumping grounds for unmerged LuaJIT pull requests, which is hardly an ideal solution in itself. Anyway, closing this. |
This seems to work fine as I'm currently using it: