New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stepmania: fix runtime crash when built with new versions of gcc. #16630
Conversation
hey, it would be nice to have this merged as the current build of stepmania crashes out of the box |
Current template built with external ffmpeg. Please switch to system ffmpeg. |
This is for building with system ffmpeg. Build failure, though. diff --git a/srcpkgs/stepmania/template b/srcpkgs/stepmania/template
index b416cfa4a5..7e0355708c 100644
--- a/srcpkgs/stepmania/template
+++ b/srcpkgs/stepmania/template
@@ -3,10 +3,11 @@ pkgname=stepmania
version=5.0.12
revision=3
build_style=cmake
+configure_args="-DWITH_SYSTEM_FFMPEG=ON"
cmake_builddir="Build"
-hostmakedepends="nasm yasm pkg-config git"
+hostmakedepends="nasm yasm pkg-config"
makedepends="libmad-devel libvorbis-devel pcre-devel libjpeg-turbo-devel
-alsa-lib-devel libXrandr-devel libva-devel glew-devel"
+alsa-lib-devel libXrandr-devel libva-devel glew-devel ffmpeg-devel"
short_desc="Advanced rhythm game"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="MIT" |
@sgn Original author abandoned this PR? Do you want to manually fix this up or should I do it? |
Hi @travankor If you can make this works with system ffmpeg, I'll merge it. |
@sgn Seems like this commit is necessary, but it is on git master (no releases). This looks difficult to backport to old versions. |
I know this is old, but stepmania development has taken a new direction with the OutFox branch (stepmania 5.3). Technically nonfree for now. I know one of the developers personally and they plan to eventually make open source. Should this still be fixed and any PR I create have a different package name i.e. 'stepmania-outfox' or should I just make a PR for the new stepmania with the same package name? |
@jason1987d When the new open source version is up, I think we should just update this one. |
Closes: void-linux#16630 [via git-merge-pr]
Closes: void-linux#16630 [via git-merge-pr]
patch comes from stepmania/stepmania@3f64564