Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepmania: fix runtime crash when built with new versions of gcc. #16630

Closed
wants to merge 1 commit into from
Closed

stepmania: fix runtime crash when built with new versions of gcc. #16630

wants to merge 1 commit into from

Conversation

aliasless
Copy link
Contributor

patch comes from stepmania/stepmania@3f64564

@Francesco149
Copy link
Contributor

hey, it would be nice to have this merged as the current build of stepmania crashes out of the box

@sgn
Copy link
Member

sgn commented Apr 19, 2020

Current template built with external ffmpeg. Please switch to system ffmpeg.

@sgn
Copy link
Member

sgn commented Apr 19, 2020

This is for building with system ffmpeg. Build failure, though.

diff --git a/srcpkgs/stepmania/template b/srcpkgs/stepmania/template
index b416cfa4a5..7e0355708c 100644
--- a/srcpkgs/stepmania/template
+++ b/srcpkgs/stepmania/template
@@ -3,10 +3,11 @@ pkgname=stepmania
 version=5.0.12
 revision=3
 build_style=cmake
+configure_args="-DWITH_SYSTEM_FFMPEG=ON"
 cmake_builddir="Build"
-hostmakedepends="nasm yasm pkg-config git"
+hostmakedepends="nasm yasm pkg-config"
 makedepends="libmad-devel libvorbis-devel pcre-devel libjpeg-turbo-devel
-alsa-lib-devel libXrandr-devel libva-devel glew-devel"
+alsa-lib-devel libXrandr-devel libva-devel glew-devel ffmpeg-devel"
 short_desc="Advanced rhythm game"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="MIT"

@travankor
Copy link
Contributor

@sgn Original author abandoned this PR? Do you want to manually fix this up or should I do it?

@sgn
Copy link
Member

sgn commented May 9, 2020

Hi @travankor

If you can make this works with system ffmpeg, I'll merge it.
I'm busy with libreoffice in aarch64 now.

@travankor
Copy link
Contributor

@sgn Seems like this commit is necessary, but it is on git master (no releases). This looks difficult to backport to old versions.

@jason1987d
Copy link
Contributor

I know this is old, but stepmania development has taken a new direction with the OutFox branch (stepmania 5.3). Technically nonfree for now. I know one of the developers personally and they plan to eventually make open source. Should this still be fixed and any PR I create have a different package name i.e. 'stepmania-outfox' or should I just make a PR for the new stepmania with the same package name?

@ericonr
Copy link
Member

ericonr commented Jun 8, 2021

@jason1987d When the new open source version is up, I think we should just update this one.

@ericonr ericonr closed this in aaa1d6a Jun 8, 2021
uncomfyhalomacro pushed a commit to uncomfyhalomacro/void-packages that referenced this pull request Jun 12, 2021
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Jun 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants