PopCorn: add logging

[the-antz]

This prevents PopCorn from printing warnings to tty1 because of a (not
yet) available network connection.

[steinex]

I'd rather that PopCorn does not print the "Retrying ping" message, because it has that functionality built in already.

[the-antz]

Should I change it to redirect popcorns stdout/stderr to /dev/null instead?

Or remove the message from popcorn itself?

[Piraty]

My opinion: Service supervisors should not be (ab)used to fix broken daemons and their inability to handle unmet prerequisites properly (I'm looking at systemd's service dependencies for example, which people like to use to ensure other functionality – like network etc – is available before a service starts, instead of properly checking prereqs in their own code)

[the-maldridge]

A log service should be added which writes the output to a file rather than to the default, which is tty1 for all runit managed services..

[the-antz]

A log service should be added which writes the output to a file rather than to the default, which is tty1 for all runit managed services..

Like a --syslog or --log filename parameter for the popcorn client?

Or is something like 1>>${LOGFILE_INFO} 2>>${LOGFILE_ERR} in the runit script an acceptable way of doing it?

For now I prefix the commit message with [NOMERGE] while I dig deeper into this, I hope that's the correct way of doing it (I'm fairly newish to this).

edit:
After looking at popcorns source, it turns out "Retrying ping" is the only message that goes to stdout, all other messages go to stderr.
What do you think about changing the run script to redirect stdout to /dev/null while keeping stderr as is?

[Duncaen]

Something like:

mkdir srcpkgs/PopCorn/files/popcorn/log
ln -s /usr/bin/vlogger srcpkgs/PopCorn/files/popcorn/log/run

And maybe exec 2>&1 in srcpkgs/PopCorn/files/popcorn/run if the messages end up on stderr.

Edit: this will log the messages by default to syslog with the flexibility of being able to use vlogger to redirect them to files using a /etc/vlogger script.

[the-antz]

PR updated. The new dependency util-linux provides vlogger.

[Duncaen]

vlogger is part of runit-void I don't think you need to add a dependency for that, if you use the runit service you most likely have runit-void installed.

[the-antz]

Fixed :)

[the-maldridge]

Shouldn't this have a #! and an exec?

[the-antz]

The file is a symlink to /usr/bin/vlogger.