Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: lexbor-0.4.0 #17012

Closed
wants to merge 1 commit into from
Closed

New package: lexbor-0.4.0 #17012

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Dec 2, 2019

Closes #17001

Signed-off-by: Nathan Owens ndowens04@gmail.com

@LinArcX
Copy link
Contributor

LinArcX commented Dec 2, 2019

Thank you so much, but there are two points that i want to mention:
1- when you build lexbor from source, it generate multiple .so files:

liblexbor-core.so
liblexbor-css.so
liblexbor-dom.so
liblexbor-encoding.so
liblexbor-html.so
liblexbor-ns.so
liblexbor-tag.so
liblexbor-utils.so

But in your package, just liblexbor.so added to shlibs files.

2- I'm using this lib with cmake for my project. in cmake you can specify libs via pkg-config. but it can't find lexbor:

pkg-config --list-all | grep lexbor

@ndowens ndowens changed the title New package: lexbor-0.4.0 [No Merge] New package: lexbor-0.4.0 Dec 2, 2019
@ndowens
Copy link
Contributor Author

ndowens commented Dec 2, 2019

Thank you so much, but there are two points that i want to mention:
1- when you build lexbor from source, it generate multiple .so files:

liblexbor-core.so
liblexbor-css.so
liblexbor-dom.so
liblexbor-encoding.so
liblexbor-html.so
liblexbor-ns.so
liblexbor-tag.so
liblexbor-utils.so

But in your package, just liblexbor.so added to shlibs files.

2- I'm using this lib with cmake for my project. in cmake you can specify libs via pkg-config. but it can't find lexbor:

pkg-config --list-all | grep lexbor

As far as I know, pkg-config works with .pc(pkgconfig files), but this project doesn't get generated with one. Also I didn't enable separate library build, so it only builds as one library

@ndowens
Copy link
Contributor Author

ndowens commented Dec 2, 2019

@LinArcX I added pkg-config support, though this if my first time of writing one, could you test this and see if it works? From my testing, it seems to work, as the actual LDFLAG is -lliblexbor

Edit: Separated the files a bit and created a -devel pkg, so the shared library and headers are in it.

@LinArcX
Copy link
Contributor

LinArcX commented Dec 3, 2019

I installed lexbor and liblexbor-devel. Second package had a .pc file.(That is what i want)
And also I'm using cmake, it can find lexbor via pkg-config, but seems it can't find the .so files related to liblexbor-dom.so and liblexbor-html.so.

I created a test project:
https://github.com/LinArcX/mgr

And this is the output of cmake:
https://gist.github.com/LinArcX/1ebf25acd2edaced36318042534bc9ab

So i think if you add those .so files that i mentioned in previous comment, this issue will fix too.

@ndowens
Copy link
Contributor Author

ndowens commented Dec 3, 2019

I installed lexbor and liblexbor-devel. Second package had a .pc file.(That is what i want)
And also I'm using cmake, it can find lexbor via pkg-config, but seems it can't find the .so files related to liblexbor-dom.so and liblexbor-html.so.

I created a test project:
https://github.com/LinArcX/mgr

And this is the output of cmake:
https://gist.github.com/LinArcX/1ebf25acd2edaced36318042534bc9ab

So i think if you add those .so files that i mentioned in previous comment, this issue will fix too.
Edit: Ok I separated them and created pc files for them but the makefile still gives the error.

@ndowens
Copy link
Contributor Author

ndowens commented Dec 4, 2019

I retried it myself, and I figured out what it is, the make file isn't adding LDFLAGS. On the test project, I did a PR on it, so you can see it works.

@LinArcX
Copy link
Contributor

LinArcX commented Dec 4, 2019

I found a solution that doesn't need even path for pkg-config:
https://github.com/LinArcX/mgr/pull/1#issuecomment-561533782
And now everything works like a charm.

Closes #17001

Signed-off-by: Nathan Owens <ndowens04@gmail.com>
@ndowens ndowens changed the title [No Merge] New package: lexbor-0.4.0 New package: lexbor-0.4.0 Dec 4, 2019
@ndowens ndowens closed this Jan 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: lexbor
2 participants