WIP: New packages: ta-lib-0.4.0, python-ta-lib-0.4.17 #17161
Conversation
jpmenil
force-pushed
the
ta-lib-0.4.0_1
branch
from
f6cb696
to
cd1426c
Compare
|
Why do we need library? Any application will use it? |
|
@Chocimier i'm preparing a PR for python-ta-lib. |
just to be sure to understand, you want me to add both python-ta-lib and ta-lib-devel in the same PR, right ? |
jpmenil
force-pushed
the
ta-lib-0.4.0_1
branch
from
d87f6f0
to
aabcc76
Compare
jpmenil
changed the title
|
Build failed is expected since python-ta-lib cannot be build without ta-lib installed. |
There was a problem hiding this comment.
just to be sure to understand, you want me to add both python-ta-lib and ta-lib-devel in the same PR, right ?
Yes, in general dependencies should go in one PR with desired package.
We do not accept new python2 packages, please add only python3-ta-lib.
Adding ta-lib-devel to makedepends make python module build.
Module contains compiled part, so isn't nocross.
Please add checkdepends="python3-nose python3-pandas".
|
|
Also please set nocross="python3-numpy is nocross" on module. |
|
sorry for the disagreement :( |
| pkgname=python3-ta-lib | ||
| version=0.4.17 | ||
| revision=1 | ||
| archs=noarch |
There was a problem hiding this comment.
Module contains compiled part, so isn't noarch.
| archs=noarch | ||
| wrksrc="TA-Lib-${version}" | ||
| build_style=python3-module | ||
| pycompile_module="talib" |
There was a problem hiding this comment.
There is no need to set this from some time ago.
| wrksrc="TA-Lib-${version}" | ||
| build_style=python3-module | ||
| pycompile_module="talib" | ||
| hostmakedepends="python-setuptools python3-setuptools" |
There was a problem hiding this comment.
python-setuptools was only needed for python2 variant
| @@ -0,0 +1,19 @@ | |||
| # Template file for 'ta-lib-devel' | |||
| pkgname=ta-lib-devel | |||
There was a problem hiding this comment.
Should be split to ta-lib and ta-lib-devel, like eg. libarchive. Then -devel goes to makedepends and lib to depends.
|
closing this one, since theses libs are a bit outdated. |
No description provided.