Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hedgewars: fix ppc build #17759

Merged
merged 1 commit into from Dec 26, 2019
Merged

hedgewars: fix ppc build #17759

merged 1 commit into from Dec 26, 2019

Conversation

nashimus
Copy link
Contributor

No description provided.

@q66
Copy link
Contributor

q66 commented Dec 24, 2019

I think this template could use a better refactor. Also, what are the differences between the C and fpc engine?

Some suggestions:

  • only add fpc in hostmakedepends conditionally instead of sed'ing it away
  • don't conditionalize the C engine for ppc*, instead use it for everything except x86_64, as a single case, since fpc is only available on x86
  • for the cflags removal, conditionalize it with some kind of $_use_c variable and set _use_c=yes when using the C engine

@nashimus
Copy link
Contributor Author

Thank you for the suggestions. I wasn't aware of the state of fpc on other archs, that's good to know, it would be nice to fix it for as many as possible.

Hedgewars pas2CTutorial

Pas2C is an alternative way to build the engine. It is disabled by default.

Pas2C is intended to be used when building the engine natively (e.g. with FreePascal) fails for some reason. However, Pas2C does have some limitations and you should try to first build Hedgewars normally before attempting a Pas2C build.

Pas2C is our hand-written Pascal-to-C-compiler. It works by converting all Pascal code to C, and then compiling the C code with a C compiler. Pas2C itself is written in Haskell. Yes, we're a little crazy. :-)

The Pas2C build currently doesn't support the video recorder.

srcpkgs/hedgewars/template Outdated Show resolved Hide resolved
srcpkgs/hedgewars/template Outdated Show resolved Hide resolved
@q66
Copy link
Contributor

q66 commented Dec 25, 2019

Also, please squash your commits and reword the commit message as something more up to date

@q66
Copy link
Contributor

q66 commented Dec 26, 2019

lgtm

@q66 q66 merged commit 20fa8a6 into void-linux:master Dec 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants