Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-doc-utils: use python3 #18005

Closed
wants to merge 1 commit into from

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Jan 3, 2020

No description provided.

if node.isBlankNode():
if self.app.options.get('expand_entities') or \
- (not (node.prev and not node.prev.isBlankNode() and node.next and not node.next.isBlankNode()) ):
+ (not (node.prev and not node.prev.isBlankNode() and node.__next__ and not node.next.isBlankNode()) ):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with python but is the change to node.__next__ correct?

Comment on lines +479 to +481
- node.next = next
+ #print(type(next))
+ #node.next = next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comment is enough?

@paper42
Copy link
Member Author

paper42 commented Jan 3, 2020

This patch is taken from Fedora and Alpine uses it too, so I think it is correct.

@sgn sgn closed this in e3d1ba6 Jul 2, 2020
fosslinux pushed a commit to fosslinux/void-packages that referenced this pull request Jul 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
@paper42 paper42 deleted the gnome-doc-utils-python3 branch January 16, 2022 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants