fotoxx: Update to 20.04 ; Fix musl build

[ndowens]

No description provided.

[ndowens]

@xtraeme Can you relook at this please :)

[pullmoll]

@ndowens If you change the Makefile to add to LIBS, i.e. LIBS += instead of LIBS = , you can then just set LIBS="-lexecinfo" in the template and avoid the EXECINFO variable which otherwise pollutes the environment.

[ndowens]

@ndowens If you change the Makefile to add to LIBS, i.e. LIBS += instead of LIBS = , you can then just set LIBS="-lexecinfo" in the template and avoid the EXECINFO variable which otherwise pollutes the environment.

Will try that at some point today.
P.S. Seems a newer version is out, so will update to that as well.

[ndowens]

Ok, I set LIBS = to LIBS += in Makefile and added LIBS="-lexecinfo" but that does not add -lexecinfo into LIBS in Makefile

Also tried doing make_build_args="LIBS=lexecinfo" and that caused way more link errors, as that overwrote the LIBS.

@pullmoll Ok the only other way I know to do this, is to add pkg-config file for libexecinfo(which might be beneficial later on for other pkgs)

[pullmoll]

Since adding the pkg-config file makes more sense, correcting my hint is redundant.
The problem was/is that common/build-style/gnu-makefile does not pass LIBS="$LIBS" in do_build(). It should probably do that for similar cases for when make_use_env is defined.

You could also have tried to set `make_build_args="LIBS=-lexecinfo`` in the template.

Adding the library like LDFLAGS="-lexecinfo" should also have worked while IMO this is not good style because LIBS is meant to be used for adding libraries, not LDFLAGS.

[ndowens]

Yea I tried make_build_args but it made it much worse and LDFLAGS was the first thing I tried when I started working on the musl build as well. It appears to pass the flag with LDFLAGS: http://dpaste.com/3R4Z68D but it doesn't actually cause it to link.

…

On Sat, Jan 11, 2020 at 6:13 AM Jürgen Buchmüller ***@***.***> wrote: Since adding the pkg-config file makes more sense, correcting my hint is redundant. The problem was/is that common/build-style/gnu-makefile does not pass LIBS="$LIBS" in do_build(). It should probably do that for similar cases for when make_use_env is defined. You could also have tried to set `make_build_args="LIBS=-lexecinfo`` in the template. Adding the library like LDFLAGS="-lexecinfo" should also have worked while IMO this is not good style because LIBS is meant to be used for adding libraries, not LDFLAGS. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18045?email_source=notifications&email_token=AAA4X37XI6IQWOHJIZ6CFPTQ5GZVDA5CNFSM4KCZDNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWAUYA#issuecomment-573311584>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA4X36WFLGMQW6IDY7ZFQLQ5GZVDANCNFSM4KCZDNLA> .