Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux5.4: update to 5.4.11 #18278

Closed
wants to merge 2 commits into from
Closed

linux5.4: update to 5.4.11 #18278

wants to merge 2 commits into from

Conversation

bgkillas
Copy link

@bgkillas bgkillas commented Jan 12, 2020

linux5.4: update to 5.4.11

@bgkillas
Copy link
Author

seems that the checks failed ig i dont understand

@abenson
Copy link
Contributor

abenson commented Jan 12, 2020

  1. Please follow the convention for commit messages: <pkgname>: update to <version>.
  2. Checksum needs to be updated
  3. Need to test configs as well, as there might be changes

@bgkillas bgkillas changed the title update linux 5.4 linux5.4: update to 5.4.11 Jan 12, 2020
@bgkillas
Copy link
Author

idk how to find checksums i wonder if that was the right thing doesent feel like

@Duncaen
Copy link
Member

Duncaen commented Jan 13, 2020

  1. The commit message not the PR title has to follow the standard.
  2. The checksum is not correct, this comes back to having tested your changes.
  3. revision needs to be reset to 1.
  4. commits need to be squashed.

You should test the things you open a PR for, maybe a simpler template that doesn't require a lot of time to compile would be a better start.

@bgkillas
Copy link
Author

welp im to lazy giving up time

@q66 q66 closed this Jan 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants