Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "graphviz: update to 2.42.2." #18281

Closed
wants to merge 1 commit into from
Closed

Revert "graphviz: update to 2.42.2." #18281

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Jan 13, 2020

Reverting to older version, until I can solve a discovered link issue that was mentioned and I was able to reproduce

This reverts commit f0fb795.

@ndowens ndowens changed the title Revert "graphviz: update to 2.42.2." [NoMerge] Revert "graphviz: update to 2.42.2." Jan 14, 2020
@ndowens ndowens changed the title [NoMerge] Revert "graphviz: update to 2.42.2." Revert "graphviz: update to 2.42.2." Jan 14, 2020
@ndowens
Copy link
Contributor Author

ndowens commented Jan 14, 2020

I've been working on getting the new version to work.
We have two options, I can remove the problem, is that it generates header during build, so:

  1. No cross
  2. We use the header from this version into the newer version.

@ndowens
Copy link
Contributor Author

ndowens commented Jan 14, 2020

2nd method does allow cross-builds. https://termbin.com/mf5j is the header that is suppose to be generated during build, which came from the older version by default, not created at build time.

Also installed locally and no linking errors either.

mkdefs_SOURCES = mkdefs.c

-gdefs.h: $(top_srcdir)/lib/gvpr/gprdata mkdefs$(EXEEXT)
- ./mkdefs$(EXEEXT) gdefs.h < $(top_srcdir)/lib/gvpr/gprdata
Copy link
Member

@pullmoll pullmoll Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to add build_helper="qemu" to the template and patch this line to

        qemu-${XBPS_TARGET_QEMU_MACHINE}-static ./mkdefs$(EXEEXT) gdefs.h < $(top_srcdir)/lib/gvpr/gprdata

in e.g. pre_configure() and inside a block

        if [ "$CROSS_BUILD" ]; then
                vsed -i lib/gvpr/Makefile.am -e "s;\./mkdefs;qemu-${XBPS_TARGET_QEMU_MACHINE}-static &;"
        fi

Then cross builds will run mkdefs under qemu.

@jnbr
Copy link
Contributor

jnbr commented May 15, 2020

switch to cmake was reverted, graphviz was update to 2.44.0.

@jnbr jnbr closed this May 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants