Carla: add patch for gcc 9 #18662
Merged
Carla: add patch for gcc 9 #18662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgn
force-pushed
the
carla-gcc-9-patch
branch
from
c35ec66
to
c422a06
Compare
|
Package lacks python files, is it ok? |
|
On 2020-01-30 09:49:29-0800, Piotr ***@***.***> wrote:
Package lacks python files, is it ok?
Python files are located inside `/usr/share/carla`, as same as before.
It's declared in the template, `pycompile_dirs=usr/share/carla`
…--
Danh
|
|
There isn't even /usr/share, see travis log. |
Well, it does show up on x86_64-musl build, Since I only built for x86_64-musl in my local machine, |
sgn
force-pushed
the
carla-gcc-9-patch
branch
2 times, most recently
from
5e177ae
to
458429b
Compare
|
On 2020-01-31 12:00:21-0800, Piotr ***@***.***> wrote:
There isn't even /usr/share, see travis log.
I fixed that problem, turn out it needs which to detect that
compilation script.
And the cross-compiled packages missed /usr/share from very begining,
since python3-PyQt5-devel-tools should be in the hostdepends
I bumped the revision to trigger the rebuild to correct it.
…--
Danh
|
|
Needs Adjust pycompile_version. Pycompile_module controls compilation of files in site-packages, but there are no in package, so no need to set. Test without -n is preferred here. |
|
On 2020-02-03 12:12:58-0800, Piotr ***@***.***> wrote:
Needs `which` in runtime too, please add it to depends.
OK, /usr/bin/carla requires which, damn.
Adjust pycompile_version. Pycompile_module controls compilation of
files in site-packages, but there are no in package, so no need to
set.
IIUC, remove pycompile_module, and set pycompile_version=$py_ver?
Test without -n is preferred here.
It was added to trigger travis build before,
I'll remove it.
…--
Danh
|
sgn
force-pushed
the
carla-gcc-9-patch
branch
5 times, most recently
from
8a9bdeb
to
c86838d
Compare
|
Yes, use py3_ver, and remove pycompile_module. Looks good beside those. |
Bump revision to trigger rebuild for platform that were cross-compiled.
sgn
force-pushed
the
carla-gcc-9-patch
branch
from
c86838d
to
4ef27a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.