New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux5.5: revamp x86_64 config from linux5.4. #18852
Conversation
Don't look at the PR diff, check the diff between the x86_64-dotconfig:
|
We should follow the 5.4 opts though; if something is worth enabling that was disabled in 5.4, it should be enabled separately, for all kernel series with the feature. |
dude
|
The 5.4 config is known to boot and work, on common setups, with nobody reporting any issues. The new 5.5 config had at least ~15 things obviously wrong, with users on IRC advising that it may not boot on their hardware at all. Why would I trust that over 5.4 base? |
I don't mind disabling GCC_PLUGINS and enabling JUMP_LABELS. |
|
I'm totally against using the "stable" non-LTS kernel as testing grounds for questionable changes. It should follow the same configuration as the LTS trees. Modules only make sense where 1) it would add too much to size of the kernel 2) it won't be loaded for majority of users. |
Because having tons of largely useless modules will increase the size of the kernel package for no reason. |
5268988
to
147f02d
Compare
Where do we even disable a feature that was available before? |
You can't know for sure but the whole point of a generic distro kernel is to ship something that is a tradeoff between size and satisfying the needs of most users. |
??? this config adds a few more drivers as modules, i dont get what you want. |
i just rebased and changed the two settings mentioned. |
I think allmodconfig does not yield good results on x86_64. I'll clean up above changes and update this PR. |
147f02d
to
a4d8956
Compare
I tried to do this once and it was not successful. But feel free to make a PR. In the mean time, I think we should merge this PR now. |
Our process is fine. Allmodconfig is a terrible idea, there's tons of modules that build on all archs yet only make sense on some of them, and a custom defconfig will only make it harder to find out what changed inbetween versions. I already looked into all this and what we have right now is the path of least pain (and fairly reliable). The only time it becomes complicated is when you make it complicated (like you did just now). |
[ci skip]
Did a clean run of make oldconfig, with the 5.4 .config preloaded. Picked defaults, or m if possible or common among this kind of config option.