New package: nextdns-1.6.4 #20022

gspe · 2020-03-11T16:22:05Z

Close #19905

smorimoto · 2020-05-28T19:01:28Z

This looks good. Can any of the maintainers review this?

Vaelatern · 2020-05-28T19:40:46Z

srcpkgs/nextdns/files/nextdns_conf

+
+# NextDNS custom configuration id
+# change id with your NextDNS id
+config id


Can this file be extracted from the download tarball?

Hi,
this file doesn't exist in tarball.
Nextdns doesn't work with Void out of the box because it doesn't support runit system, yet. Nextdns has commands:

Usage: nextdns <command> [arguments] The commands are: install install service on the system uninstall uninstall service from the system start start installed service stop stop installed service restart restart installed service status return service status log show service logs run run the daemon config manage configuration activate setup the system to use NextDNS as a resolver deactivate restore the resolver configuration version show current version

That interact directly with systemd or upstart or sysv, etc, but not runit

But it's easy to configure it to work with Void, user only have to configure config file manually and run the only NextDNS commands that work: nextdns run so you can start it with something similar:

sudo nextdns run \ -config <your config id> ...

In order to use it with Void as system service, you have to put your configuration in
/etc/nextdns/nextdns_conf file and symlink /etc/sv/nextdnsd to /var/service

To setup the system to use NextDNS as a dns resolver, un-comment the last line in /etc/resolvconf.conf to name_servers=127.0.0.1 and restart resolvconf with resolvconf -u now NextDNS should be used as dns resolver

Vaelatern · 2020-05-28T19:41:06Z

srcpkgs/nextdns/files/nextdnsd/run

@@ -0,0 +1,2 @@
+#!/bin/sh
+exec /usr/bin/nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1


exec nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1

Vaelatern · 2020-05-28T19:41:33Z

srcpkgs/nextdns/template

+homepage="https://nextdns.io/"
+distfiles="https://github.com/${pkgname}/${pkgname}/archive/v${version}.tar.gz"
+checksum=7a7c0829ca52a711f6fc813e6d913577670c95ddd8b3ab5d17da2b69440a3edc
+conf_files="/etc/nextdns/nextdns_conf"


is there a reason this is not .conf? Does upstream prefer _conf ?

Good catch. The upstream accepts arbitrary file names.

The upstream config file is created with the nextdns commands and stored internally somewhere, so I don't know its name exactly

Vaelatern · 2020-05-28T19:42:09Z

Other than the small issues above, this seems reasonable

smorimoto · 2020-05-29T00:17:59Z

srcpkgs/nextdns/template

@@ -0,0 +1,19 @@
+# Template file for 'nextdns'
+pkgname=nextdns
+version=1.4.35


Suggested change

version=1.4.35

version=1.6.3

smorimoto · 2020-05-29T00:18:23Z

srcpkgs/nextdns/template

+homepage="https://nextdns.io/"
+distfiles="https://github.com/${pkgname}/${pkgname}/archive/v${version}.tar.gz"
+checksum=7a7c0829ca52a711f6fc813e6d913577670c95ddd8b3ab5d17da2b69440a3edc
+conf_files="/etc/nextdns/nextdns_conf"


Suggested change

conf_files="/etc/nextdns/nextdns_conf"

conf_files="/etc/nextdns/nextdns.conf"

smorimoto · 2020-05-29T00:18:36Z

srcpkgs/nextdns/files/nextdnsd/run

@@ -0,0 +1,2 @@
+#!/bin/sh
+exec /usr/bin/nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1


Suggested change

exec /usr/bin/nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1

exec nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1

smorimoto · 2020-05-29T12:39:32Z

Thanks @gspe!

Vaelatern · 2020-05-31T02:11:25Z

srcpkgs/nextdns/files/nextdns.conf

+
+# NextDNS custom configuration id
+# change id with your NextDNS id
+config id


I still don't like having this config file in our tree. Is there any way around this?

What would be your recommendation?

@Vaelatern there are two solutions:

remove this config file from package and tell users to create one them self

add runit support in nextdns, this would be quite easy task since runit is very simple init system to deal with. But some one have to do this

If upstream does not ship with a configuration file, neither do we.

It's ok for the runit script to not work out of the box, and require further reading to get it working. People are expected to be able to read their runit scripts and upstream documentation and make things work.

as of latest commit is not removed from conf_files or otherwise removed.

not done
https://files.catbox.moe/m1irr6.png

Without an example of runit and how to write a config file that runit use this software doesn't work!
So why do you want to include a non working software in the void repo?

Simply put because it's not helpful. If you want to know more, read upstream's docs on getting started. Or read the runit script and figure out what you need. Problem solved.

Example packages that use this model:

hooktftp

tgt

autox

nomad

consul

seaweedfs

netauth

are all packages we have where you really should go read upstream's documentation on how to get started. This is a good thing because it means there is less effort necessary to maintain these packages. Lower effort per package means more can be done with our lives, and that's a good thing.

abenson · 2020-06-17T15:42:20Z

srcpkgs/nextdns/template

+
+post_install() {
+	vsv nextdnsd
+	vdoc ${FILESDIR}/nextdns.conf.example


vdoc or vsconf?

Or total removal. I like total removal.

Vaelatern · 2020-06-17T21:33:22Z

srcpkgs/nextdns/files/nextdnsd/run

@@ -0,0 +1,2 @@
+#!/bin/sh
+exec nextdns run -config-file /etc/nextdns/nextdns.conf 2>&1


You can add a comment above this line, like # See https://example.com/doc for example configuration

There isn't a clear documentation about config file, the only helpful link is this https://github.com/nextdns/nextdns/wiki/Configuration-File-Format but it doesn't explain that you have to use your config id etc...
So I think that the best thing to do is to provide an example config-file in doc dir, so users are free to use it or do more research them self.

@gspe: The best thing to do in this case is to ask upstream to improve their documentation, in the form of a well-commented example config file[1]. Upstream knows the software best, and can make sure such a file is properly maintained and contains the correct information. We shouldn't be trying to take on that task.

[1] Cf. e.g. the extensively-commented sample wpa_supplicant.conf file provided by upstream.

github-actions · 2022-04-16T02:02:06Z

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Vaelatern reviewed May 28, 2020

View reviewed changes

smorimoto reviewed May 29, 2020

View reviewed changes

gspe force-pushed the nextdns branch from b82108a to 6dc2b48 Compare May 29, 2020 07:58

gspe changed the title ~~New package: nextdns-1.4.35~~ New package: nextdns-1.6.3 May 29, 2020

Vaelatern reviewed May 31, 2020

View reviewed changes

gspe force-pushed the nextdns branch from 6dc2b48 to 58089db Compare June 10, 2020 20:46

gspe changed the title ~~New package: nextdns-1.6.3~~ New package: nextdns-1.6.4 Jun 10, 2020

gspe force-pushed the nextdns branch 2 times, most recently from 441b2b8 to b70eb11 Compare June 11, 2020 12:02

New package: nextdns-1.6.4

04a3f74

gspe force-pushed the nextdns branch from b70eb11 to 04a3f74 Compare June 11, 2020 19:27

abenson reviewed Jun 17, 2020

View reviewed changes

Vaelatern reviewed Jun 17, 2020

View reviewed changes

ericonr added the new-package This PR adds a new package label Dec 20, 2020

anubhavkini mentioned this pull request May 9, 2021

New package: nextdns-1.32.2 #30603

Closed

3 tasks

github-actions bot added the Stale label Apr 16, 2022

github-actions bot closed this Apr 30, 2022

RunningDroid mentioned this pull request Oct 12, 2022

New package: nextdns-1.39.4 #39903

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New package: nextdns-1.6.4 #20022

New package: nextdns-1.6.4 #20022

gspe commented Mar 11, 2020

smorimoto commented May 28, 2020

Vaelatern May 28, 2020

smorimoto May 28, 2020

gspe May 29, 2020

Vaelatern May 28, 2020

gspe May 29, 2020

Vaelatern May 28, 2020

smorimoto May 28, 2020

gspe May 29, 2020

Vaelatern commented May 28, 2020

smorimoto May 29, 2020

gspe May 29, 2020

smorimoto May 29, 2020

gspe May 29, 2020

smorimoto May 29, 2020

smorimoto commented May 29, 2020

Vaelatern May 31, 2020

smorimoto May 31, 2020

rs May 31, 2020

gspe May 31, 2020

Vaelatern May 31, 2020

Vaelatern Jun 10, 2020

gspe Jun 11, 2020

Vaelatern Jun 11, 2020

gspe Jun 12, 2020 •

edited

Vaelatern Jun 14, 2020

abenson Jun 17, 2020

Vaelatern Jun 17, 2020

Vaelatern Jun 17, 2020

gspe Jun 21, 2020

flexibeast Jun 21, 2020

github-actions bot commented Apr 16, 2022

		@@ -0,0 +1,2 @@
		#!/bin/sh
		exec /usr/bin/nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1

	conf_files="/etc/nextdns/nextdns_conf"
	conf_files="/etc/nextdns/nextdns.conf"

	exec /usr/bin/nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1
	exec nextdns run -config-file /etc/nextdns/nextdns_conf 2>&1

New package: nextdns-1.6.4 #20022

New package: nextdns-1.6.4 #20022

Conversation

gspe commented Mar 11, 2020

smorimoto commented May 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vaelatern commented May 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smorimoto commented May 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gspe Jun 12, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 16, 2022

gspe Jun 12, 2020 •

edited