New package: hyperrogue-11.3f

[xelxebar]

No description provided.

[xelxebar]

For some reason, /usr/include/SDL/SDL_gfxPrimitives.h from SDL_gfx-devel has

#include <SDL.h>

whereas SDL-devel installs that header to /usr/include/SDL/SDL.h. That is why pre_build has that symlink hack.

[xelxebar]

Ugh. Crossbuilds are broken. Looks like upstream is generating some source from one of the output binaries, thus said binary needs to run on the host instead of target. Worked around it by forcing x86_64 in archs for now, but will try finding something better.

[travankor]

What about https://github.com/zenorogue/hyperrogue/blob/master/Makefile.simple?

[xelxebar]

What about https://github.com/zenorogue/hyperrogue/blob/master/Makefile.simple?

That makefile contains no install target.

[xelxebar]

cannot be built with SDL2?

Not without a non-trivial patch:

$ grep -r 'SDL/SDL.h' masterdir/builddir/hyperrogue-11.3f
masterdir/builddir/hyperrogue-11.3f/.travis.yml:    (cd /usr/local/include && ln -sf SDL/SDL.h)
masterdir/builddir/hyperrogue-11.3f/configure.ac:AC_CHECK_HEADERS([SDL/SDL.h], [], AC_MSG_ERROR([SDL/SDL.h header was not found]))
masterdir/builddir/hyperrogue-11.3f/fake-mobile.cpp:#include <SDL/SDL.h>
masterdir/builddir/hyperrogue-11.3f/savepng.cpp:#include <SDL/SDL.h>
masterdir/builddir/hyperrogue-11.3f/sysconfig.h:#include <SDL/SDL.h>

$ xlocate SDL/SDL.h
SDL-devel-1.2.15_12	/usr/include/SDL/SDL.h

Apparently, SDL2 isn't just a drop-in replacement for SDL. For the former, some headers look to be named like SDL_* while others are SDL2_*. Same goes for function names.

[xelxebar]

Replaced the symlink hack with a CXXFLAGS setting. Much better.

[Johnnynator]

You do miss some licenses CC BY-SA 4.0, CC BY 3.0, Public Domain for various sounds. Also set nocross="Reason" instead of setting archs. Also is it possible to use system DejaVuSans-Bold instead of installing a own one?

[xelxebar]

You do miss some licenses CC BY-SA 4.0, CC BY 3.0, Public Domain for various sounds.

Very nice catch. I found the same by scrounging around and ending up at sounds/credits.txt. Did you do the same? That was very non-obvious to me.

What are some general thinks to keep in mind to avoid missing licenses in the future? Games and anything with artwork seems likely to have several licenses for those parts.

Also set nocross="Reason" instead of setting archs.

Much better. Thank you.

Also is it possible to use system DejaVuSans-Bold instead of installing a own one?

I have no idea. Submit a patch if you like.

[Johnnynator]

What are some general thinks to keep in mind to avoid missing licenses in the future? Games and anything with artwork seems likely to have several licenses for those parts.

Ideally a program/game would just list everything in the root directory, so one wouldn't need to dig. Assets (Sounds, Graphics) are usually licensed differently, so it is usually unlikely that everything is GPL, digging into the subdirs and looking for textfiles there usually helps find these.

I have no idea. Submit a patch if you like.

Just checked the code, it is currently hardcoded. And would require a patch for hyperrogue itself. So just keep it, makes it the 12th copy of it in the repo :D

[Johnnynator]

I missed the soundtrack license. (./hyperrogue-music.txt)

HyperRogue soundtrack under the Creative Commons BY-SA 3.0 license, http://creativecommons.org/licenses/by-sa/3.0/

[xelxebar]

Thanks for the tips. Just for kicks, I went ahead and did a grep carpet bomb:

$ grep -ri license masterdir/builddir/hyperrogue-11.3f

which turned up lots of different results. It looks like mingw.* stuff is under the BSD 2-clause while dll/* is under the MIT. Those are clearly Windows-specific, but how should these be handled?

Just checked the code, [the path to DejaVuSans-Bold] is currently hardcoded. And would require a patch for hyperrogue itself. So just keep it, makes it the 12th copy of it in the repo :D

That's ridiculous. I see why you requested using the system font.

[Johnnynator]

Those are clearly Windows-specific, but how should these be handled?

Everything that doesn't get installed or used in the build process is (mostly) irrelevant, and doesn't need to be mentioned in the license field.

[xelxebar]

Beautiful. Thanks.