-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: gtkgreet-0.7 #20873
New package: gtkgreet-0.7 #20873
Conversation
644e66a
to
434edc8
Compare
1c69bbb
to
852d7e4
Compare
Squash these into two |
Version 0.6.1 of greetd seems to crash on start up, which is why I haven't squashed it yet. |
Did you manage to report this? |
Hello friends what is the status of this PR / any assistance required (I offer as tribute) |
@tsujp Feel free to take this PR over if you would like Otherwise, I will try and fix this in a few more days (sorry for the delay!) |
@@ -0,0 +1 @@ | |||
In order for agreety to work correctly, disable the agetty service for the tty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is relevant on the latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe should be added to README.voidlinux
instead of INSTALL.msg
Ready for review (again) |
@travankor I tried testing this on my laptop, but it looks like I locked myself out and unable to login on any TTY 😅 What I did is installed this package and updated the greetd config to start Here's what happens on every TTY and I can't type in the login/password. Any suggestions? |
@kkga TBH greetd doesn’t handle bad configurations very well. I haven’t run into this error where all TTY’s are taken, but I have seen errors where greetd hangs the system. You should be able to login again by booting to single user mode and disabling the greetd service. As for the specific configuration error, I’m not sure yet. Greetd switched the config file to |
I added both greeters for testing purposes, but I only want one greeter packaged. (will squash after review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering how I feel about adding a new DM... Has it been security reviewed a bit, at least?
I mostly want to avoid a repeat of emptty (which had a few glaring issues found after it was added to repos). Pinging @Duncaen to see if he's interested in anything.
@@ -0,0 +1 @@ | |||
In order for agreety to work correctly, disable the agetty service for the tty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe should be added to README.voidlinux
instead of INSTALL.msg
for i in man/*.scd; do | ||
scdoc < "$i" > "${i:: -4}" | ||
done | ||
|
||
for f in man/*-[0-9]; do | ||
num="${f: -1}" | ||
mv "$f" "${f/-$num/.$num}" | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meson.build
doesn't do the dance for us? :(
Ah, cargo
rm -f "${DESTDIR}"/usr/.crates.toml | ||
rm -f "${DESTDIR}"/usr/.crates2.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this ever copied there??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is normally part of do_install()
for the cargo build style, but I moved it to post_install()
since there is a custom do_install()
.
Got a SHA256 mismatch while trying to test this out tonight:
Edit: Probably not related to the above, but here's the output I got beforehand from my first shot at packaging
|
iirc ericonr said sourcehut changed compression for the sources. PR's checksum is old and needs to be updated |
No description provided.