Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: gtkgreet-0.7 #20873

Closed
wants to merge 4 commits into from
Closed

Conversation

travankor
Copy link
Contributor

No description provided.

@travankor travankor changed the title New package: gtkgreet-0.5 [WIP] New package: gtkgreet-0.5 Apr 11, 2020
@travankor travankor force-pushed the gtkgreet branch 2 times, most recently from 644e66a to 434edc8 Compare April 11, 2020 19:02
@travankor travankor changed the title [WIP] New package: gtkgreet-0.5 New package: gtkgreet-0.5 Apr 11, 2020
@travankor travankor changed the title New package: gtkgreet-0.5 New package: gtkgreet-0.6 May 26, 2020
@travankor travankor force-pushed the gtkgreet branch 2 times, most recently from 1c69bbb to 852d7e4 Compare May 26, 2020 08:43
@abenson
Copy link
Contributor

abenson commented Jun 17, 2020

Squash these into two New package commits

@travankor
Copy link
Contributor Author

travankor commented Jun 25, 2020

Version 0.6.1 of greetd seems to crash on start up, which is why I haven't squashed it yet.

@ericonr
Copy link
Member

ericonr commented Jul 24, 2020

Did you manage to report this?

@tsujp
Copy link

tsujp commented Nov 29, 2020

Hello friends what is the status of this PR / any assistance required (I offer as tribute)

@travankor
Copy link
Contributor Author

@tsujp Feel free to take this PR over if you would like

Otherwise, I will try and fix this in a few more days (sorry for the delay!)

@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@travankor travankor changed the title New package: gtkgreet-0.6 New package: gtkgreet-0.7 Dec 24, 2020
@@ -0,0 +1 @@
In order for agreety to work correctly, disable the agetty service for the tty
Copy link
Contributor Author

@travankor travankor Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is relevant on the latest version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe should be added to README.voidlinux instead of INSTALL.msg

@travankor
Copy link
Contributor Author

Ready for review (again)

@kkga
Copy link
Contributor

kkga commented Jan 22, 2021

@travankor I tried testing this on my laptop, but it looks like I locked myself out and unable to login on any TTY 😅

What I did is installed this package and updated the greetd config to start sway, according to the greetd wiki page.

Here's what happens on every TTY and I can't type in the login/password.

Any suggestions?

image

@travankor
Copy link
Contributor Author

travankor commented Jan 23, 2021

@kkga TBH greetd doesn’t handle bad configurations very well. I haven’t run into this error where all TTY’s are taken, but I have seen errors where greetd hangs the system.

You should be able to login again by booting to single user mode and disabling the greetd service.

As for the specific configuration error, I’m not sure yet. Greetd switched the config file to greetd.conf, but the old path should still be supported. There’s an IRC channel #kennylevinsen where the main author can help, too.

@travankor
Copy link
Contributor Author

travankor commented Jan 23, 2021

On second thought, I think I should replace gtkgreet with a different greeter since I don't want to be locked out if gtk or gtk-layer-shell breaks on an update. I think either wlgreet or tuigreet are good choices.

@travankor
Copy link
Contributor Author

I added both greeters for testing purposes, but I only want one greeter packaged. (will squash after review)

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering how I feel about adding a new DM... Has it been security reviewed a bit, at least?

I mostly want to avoid a repeat of emptty (which had a few glaring issues found after it was added to repos). Pinging @Duncaen to see if he's interested in anything.

@@ -0,0 +1 @@
In order for agreety to work correctly, disable the agetty service for the tty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe should be added to README.voidlinux instead of INSTALL.msg

Comment on lines +23 to +30
for i in man/*.scd; do
scdoc < "$i" > "${i:: -4}"
done

for f in man/*-[0-9]; do
num="${f: -1}"
mv "$f" "${f/-$num/.$num}"
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meson.build doesn't do the dance for us? :(

Ah, cargo

Comment on lines +47 to +48
rm -f "${DESTDIR}"/usr/.crates.toml
rm -f "${DESTDIR}"/usr/.crates2.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this ever copied there??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is normally part of do_install() for the cargo build style, but I moved it to post_install() since there is a custom do_install().

@muni-corn
Copy link
Contributor

muni-corn commented Mar 10, 2021

Got a SHA256 mismatch while trying to test this out tonight:

~/D/v/packages $ ./xbps-src pkg greetd wlgreet
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> greetd-0.7.0_1: removing autodeps, please wait...
=> greetd-0.7.0_1: building [cargo] [rust] for x86_64...
   [host] scdoc-1.11.1_1: found (https://alpha.de.repo.voidlinux.org/current)
   [host] cargo-0.49.0_2: found (https://alpha.de.repo.voidlinux.org/current)
   [target] pam-devel-1.5.1_1: found (https://alpha.de.repo.voidlinux.org/current)
=> greetd-0.7.0_1: installing host dependencies: scdoc-1.11.1_1 cargo-0.49.0_2 ...
=> greetd-0.7.0_1: installing target dependencies: pam-devel-1.5.1_1 ...
=> greetd-0.7.0_1: running do-fetch hook: 00-distfiles ...
=> greetd-0.7.0_1: fetching distfile '0.7.0.tar.gz'...
0.7.0.tar.gz: [0B 0%] -- stalled -- ETA: unknown
0.7.0.tar.gz: 47KB [avg rate: -- stalled --]
=> greetd-0.7.0_1: verifying checksum for distfile '0.7.0.tar.gz'... 
=> ERROR: SHA256 mismatch for '0.7.0.tar.gz:'
5229b7f00be40187de9df6240fc3b1f4012dd5e4777bb8661016cc7c2c105df7
=> ERROR: greetd-0.7.0_1: couldn't verify distfiles, exiting...

Edit: Probably not related to the above, but here's the output I got beforehand from my first shot at packaging greetd and wlgreet:

~/D/v/packages $ ./xbps-src pkg greetd wlgreet
...
31 downloaded, 1 installed, 30 updated, 31 configured, 1 removed.
=> xbps-src: cleaning up / masterdir...
=> greetd-0.7.0_1: removing autodeps, please wait...
=> greetd-0.7.0_1: building [cargo] [rust] for x86_64...
   [host] scdoc-1.11.0_1: not found
   [host] cargo-0.49.0_1: not found
   [target] pam-devel-1.3.0_2: not found
=> scdoc-1.11.0_1: building [gnu-makefile] (dependency of greetd) for x86_64...
=> scdoc-1.11.0_1: running do-fetch hook: 00-distfiles ...
=> scdoc-1.11.0_1: fetching distfile '1.11.0.tar.gz'...
1.11.0.tar.gz: [0B 0%] 100MB/s ETA: unknown
1.11.0.tar.gz: 12KB [avg rate: 309MB/s]
=> scdoc-1.11.0_1: verifying checksum for distfile '1.11.0.tar.gz'... 
=> ERROR: SHA256 mismatch for '1.11.0.tar.gz:'
45b0ac8bf787789db9ac6849d986abdd86f6e3a09fb2bc51fd15913d0aa6bf51
=> ERROR: scdoc-1.11.0_1: couldn't verify distfiles, exiting...
⏎                                                                                       ~/D/v/packages $ git pull void master
From github.com:void-linux/void-packages
 * branch                  master     -> FETCH_HEAD
Successfully rebased and updated refs/heads/gtkgreet.

@st3r4g
Copy link
Contributor

st3r4g commented Mar 14, 2021

Got a SHA256 mismatch while trying to test this out tonight:

iirc ericonr said sourcehut changed compression for the sources. PR's checksum is old and needs to be updated

@cinerea0 cinerea0 mentioned this pull request Jun 6, 2021
3 tasks
@abenson abenson closed this Nov 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants