woeusb: fix version, dependencies, split gui #20910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why create a separate template ( |
|
- binary is all lowercase
- who installed WoeUSB will still get full version with gui, until they want to remove it and install woeusb.
Anyway, you're this package maintainer, it's your call.
I don't want to pull wxWidget dependencies.
…On 12 April 2020 15:14:16 GMT+07:00, Daniel Boguslawski ***@***.***> wrote:
Why create a separate template (`woeusb`) and not just fixing the
existing one (`WoeUSB`)?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#20910 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
I think we should just change the existing one. There's no need to create a separate template IMHO |
bra1nwave
suggested changes
Apr 12, 2020
bra1nwave
reviewed
Apr 12, 2020
|
Please keep main package WoeUSB, and create WoeUSB-cli or similar with |
|
On 2020-04-14 00:23:54-0700, Piotr ***@***.***> wrote:
Please keep main package WoeUSB, and create WoeUSB-cli or similar with `vmove /`.
This is the best approach, IMHO.
…--
Danh
|
GUI version is not necessary in most case, and upstream recommend using cli tools instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split them out for reduced dependencies.