Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: update to 0.13.70. #20984

Merged
merged 1 commit into from
Apr 14, 2020
Merged

zziplib: update to 0.13.70. #20984

merged 1 commit into from
Apr 14, 2020

Conversation

mobinmob
Copy link
Contributor

  • Use cmake (per upstream recomendation).
  • Do not build static libs (upstream default).
  • Do not build docs (seems the python scripts are broken).
  • Use python3.

@mobinmob
Copy link
Contributor Author

mobinmob commented Apr 14, 2020 •
edited

upstream recommending disabling static libs is because of glibc. But we do support musl, so static libs are still useful in case you want to make a static executable.

Thank you, I will enable them ;)

@mobinmob mobinmob closed this Apr 14, 2020
@mobinmob mobinmob reopened this Apr 14, 2020
@mobinmob
Copy link
Contributor Author

It does not build a static lib even with the relevant switch in configure_args (-DBUILD_STATIC_LIBS=ON).

@mobinmob
Copy link
Contributor Author

I disabled tests in CROSS_BUILD. They depend on a generated binary and fail. Tested locally (aarch64-musl).

@xtraeme xtraeme merged commit 24b9858 into void-linux:master Apr 14, 2020
@mobinmob mobinmob deleted the zziplib branch April 16, 2020 08:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mobinmob