Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroinstall-injector: rename to zeroinstall, update to 2.16. #21039

Closed
wants to merge 1 commit into from

Conversation

mobinmob
Copy link
Contributor

Update to new version (ocaml rewrite), rename and adopt.
Based on #18155 and #19563 .

@mobinmob
Copy link
Contributor Author

mobinmob commented Apr 15, 2020

c-i builds fail (again...).
It builds and works fine on my x86_64 system :)

srcpkgs/zeroinstall/template Outdated Show resolved Hide resolved
srcpkgs/zeroinstall/template Show resolved Hide resolved
srcpkgs/zeroinstall/template Outdated Show resolved Hide resolved
srcpkgs/zeroinstall/template Outdated Show resolved Hide resolved
@mobinmob mobinmob force-pushed the zeroinstall branch 2 times, most recently from 7247891 to 3f842d9 Compare April 17, 2020 01:06
@Piraty
Copy link
Member

Piraty commented Apr 17, 2020

travis fails

@mobinmob
Copy link
Contributor Author

@Piraty Yes and I have no idea why...
I am actually using the ocaml version in x86_64.

@mobinmob
Copy link
Contributor Author

@Piraty
My (local) build log: https://termbin.com/lue6

@Piraty
Copy link
Member

Piraty commented Apr 19, 2020

I did a local build (rebased 3f842d9 onto 828b331) and even got a different error.
Maybe it's racy?

=> zeroinstall-2.16_1: running do_build ...
dune build --root=. --profile=release @install
dune runtest --root=. --profile=release
Error: Error: mkdir: _build/default/.dune: File exists
make: *** [Makefile:65: test] Error 1
make: *** Waiting for unfinished jobs....

@mobinmob
Copy link
Contributor Author

mobinmob commented Apr 19, 2020

I did a local build (rebased 3f842d9 onto 828b331) and even got a different error.
Maybe it's racy?

=> zeroinstall-2.16_1: running do_build ...
dune build --root=. --profile=release @install
dune runtest --root=. --profile=release
Error: Error: mkdir: _build/default/.dune: File exists
make: *** [Makefile:65: test] Error 1
make: *** Waiting for unfinished jobs....

Let me rebase onto master and try again...
I only had errors with the template when I forcibly quit the build process (CTRL+C) and tried to build again right away.
I use the default chroot method for xbps-src.

@Piraty
Copy link
Member

Piraty commented Apr 19, 2020

disable_parallel_build=yes fixes it

@mobinmob
Copy link
Contributor Author

disable_parallel_build=yes fixes it

Thank you! I rebased and pushed with the change.
Locally I had the same results with and without it, but that can be just luck. ;)

@Piraty
Copy link
Member

Piraty commented Apr 19, 2020

@mobinmob do you build with XBPS_MAKEJOBS?

@mobinmob
Copy link
Contributor Author

@Piraty Unfortunately it doesn't make sense in my machine so no.
Now I get why it builds fine for me 😝

@Piraty Piraty closed this in 7eea4c7 Apr 19, 2020
@q66
Copy link
Contributor

q66 commented Apr 21, 2020

so... why exactly does this need to install its own ocaml compiler? because this will break a ton of platforms.

@mobinmob
Copy link
Contributor Author

so... why exactly does this need to install its own ocaml compiler? because this will break a ton of platforms.

Previous version - the first I packaged- did not work with newer compilers. The current version specifies only a compiler newer than 4.0.5. I will test with the system compiler ;)

@q66
Copy link
Contributor

q66 commented Apr 21, 2020

i just tested, it's fine

@mobinmob mobinmob deleted the zeroinstall branch May 9, 2020 18:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants