Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing python_version=2 to packages the require it #21328

Merged
merged 15 commits into from
Apr 25, 2020

Conversation

ahesford
Copy link
Member

This fixes #21323, where packages use pycompile_dirs without declaring python_version or installing packages to /usr/lib/pythonX.Y to allow automatic detection of the Python version.

Adding the python_version (and a few xlint fixes) will not change the build outputs, so I have not revbumped these templates and am skipping CI.

@Chocimier
Copy link
Member

Some are python3, e.g. hugin, soundconverter.

@ahesford
Copy link
Member Author

ahesford commented Apr 25, 2020

I forgot to add the #unverified comment, but have added it in the latest push. The point is not to get the correct version in all of these packages, but to restore the default behavior to allow these packages to build as before the behavior change. I don't have the resources to check all packages at the moment.

Because you know hugin and soundconverter are py3, I've updated those packages. I've also noticed that qytdl pulls in py3 depenedents, so I've updated that template as well. The gdb package uses version-agnostic python modules, but the template specifies python3 dependencies so I've changed that one too.

@Chocimier Chocimier merged commit a1de485 into void-linux:master Apr 25, 2020
@ahesford ahesford deleted the python branch April 25, 2020 14:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken xbps-src builds as a result of pycompile and python_version behavior changes
2 participants