Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbps-src: declarative split library and development file #21721

Closed
wants to merge 5 commits into from

Conversation

sgn
Copy link
Member

@sgn sgn commented May 7, 2020

@void-linux/pkg-committers

@Vaelatern
Copy link
Member

I don't really like this. We currently don't have any other examples of magic where we create magic packagtes (other than -dbg, which is just a build option, and -32bit, same).

@q66
Copy link
Contributor

q66 commented May 8, 2020

yeah i think this is no good

@Hoshpak
Copy link
Member

Hoshpak commented May 8, 2020

I agree. Too much magic and calling shell functions like that makes the templates harder to read and potentially also makes parsing more difficult.

@Vaelatern
Copy link
Member

@sgn do you think this should be pursued?

@Chocimier
Copy link
Member

Chocimier commented May 8, 2020

One thing I found good is guessing what files to install into -lib and -devel packages.

Maybe that could be reworked as someting like vgroupinstall devel inside pkg_install?

@Anachron
Copy link
Contributor

Anachron commented May 8, 2020

^ couldnt xnew be updated in that case?

@Vaelatern
Copy link
Member

^ couldnt xnew be updated in that case?

What do you mean by this question, @Anachron ? How does xnew play into regular package building, unless you mean adding a sample devel package? (and just requiring it be deleted for most packages?)

@Anachron
Copy link
Contributor

Anachron commented May 8, 2020

xnew already has optional subpkgs with -devel support. Isnt that sufficient for new pkgs?

@travankor
Copy link
Contributor

@sgn, I think @Chocimier's suggestion is the best way to salvage the useful parts of this PR.

@sgn
Copy link
Member Author

sgn commented May 9, 2020

One thing I found good is guessing what files to install into -lib and -devel packages.

Maybe that could be reworked as someting like vgroupinstall devel inside pkg_install?

Yeah, this sounds better, doesn't harm readability and reduce the repeated code for devel and libs.

@sgn
Copy link
Member Author

sgn commented May 9, 2020

^ couldnt xnew be updated in that case?

I think vgroupinstall or vsplit is better than update xnew manually remove/add file.

@sgn sgn closed this May 15, 2020
@sgn sgn deleted the build-help-split-devel branch May 15, 2020 16:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants