fzf: install fzf.vim to Neovim plugin directory

[gbrlsnchs]

For Vim users, FZF works out of the box, but Neovim users have to
manually copy /usr/share/vim/vimfiles/plugin/fzf.vim to the proper
Neovim equivalent.

[Anachron]

True, this creates not needed files for vim users though. Not sure how to solve this.

[daniel-eys]

You don't have to copy vimfiles around, just add /usr/share/vim/vimfiles to your neovim runtimepath, so neovim can load plugins etc. from there, too.
set rtp+=/usr/share/vim/vimfiles

[gbrlsnchs]

You don't have to copy vimfiles around, just add /usr/share/vim/vimfiles to your neovim runtimepath, so neovim can load plugins etc. from there, too.
set rtp+=/usr/share/vim/vimfiles

If I only use FZF without Vim, it'll create the files anyway... this way at least it's consistent.

Also, Neovim reads /usr/share/nvim/runtime by default, so why add vimfiles to it? It has its own files.

This is more a design issue with FZF... we have to install those files, what if I want to install Vim/Neovim after I have already installed FZF, I won't have the file instaled...

[gbrlsnchs]

This PR is important for Neovim users that have FZF installed via XBPS. Vim support already existed and the files for it were installed regardless whether the user was a Vim user, so I just added support for Neovim. Unfortunately the flaw lies within FZF itself, since it is also home for the Vim plugin, when actually the plugin should be in a separate repository.

[ericonr]

You still have 4 unrelated commits in this PR.

Also, anyone not wanting to have neovim files can just noextract= the directory in a xbps.d(5) file. It's better for the package to ship complete functionality if it's available from upstream.

[gbrlsnchs]

You still have 4 unrelated commits in this PR.

Lol, sorry, just messed up the branch with my custom repository. Gonna fix that.

[ericonr]

Squash the commits ;)

[gbrlsnchs]

I have squashed the commits, however CI is timing out. 😖

[sgn]

True, this creates not needed files for vim users though. Not sure how to solve this.

Ask neovim's developers to read those files by default?

[ericonr]

Is this possible? I think certain vim plugins might not be compatible with neovim.

[sgn]

Is this possible? I think certain vim plugins might not be compatible with neovim.

Honestly, I don't know. neovim advertises itself as new (neo) vim, and provides vim alternatives, it should compatible.
Like vim in set compatible mode?

[ahesford]

I agree with @sgn. We have a number of packages that install various vim plugins and making two copies of the same plugin file to appease another editor seems foolish. We install the vim plugin because upstream provides a vim plugin. If you're not using vim, manage the mapping manually. You can even noextract vim directories if it bothers you to have them.

[ericonr]

If you're not using vim, manage the mapping manually. You can even noextract vim directories if it bothers you to have them.

Vim plugins "taking up space" isn't the issue, it's not having neovim ones.

We are already treating the vim plugin specially, by installing it manually in the template. By https://github.com/junegunn/fzf/blob/master/README-VIM.md#fzf-inside-terminal-buffer, fzf upstream expects the plugin to also work for neovim, so IMO it's our responsibility as packagers to ship it for all our vim alternatives.

neovim upstream should ideally have a way of importing plugins from vim directories, but I don't think waiting for a resolution on that should be a blocker.

[gbrlsnchs]

You can even noextract vim directories if it bothers you to have them.

The same applies for Neovim files then. Using noextract for it seems to be a solution.

Neovim is big enough to be taken into account. FZF on Arch Linux works out of the box with Neovim because files get installed for it too.

[sgn]

Hey, my fork of vim which hasn't been published read the plugin from /usr/share/svim/vimfiles, would you mind to update the PR to support my fork as well?

Anyway, my fork of Void Linux works out of the box, too, but it's heavily customised, so I couldn't merge it into void-packages.

---

This comment is a joke ;)

[gbrlsnchs]

I don't really see a reason to make fun of my concern. I'm even spending my work time patching this in order to make FZF installation a better experience for others that won't probably have time or expertise patching this same issue.

I still use my own patch for it, so for me particularly it's fine, my intention here is to help others only.

[sgn]

Let's chill my friends :-p

[ericonr]

Yes, it is unfortunate that VIM alternatives don't deal with plugins installed for the others. As it stands, I feel comfortable shipping this, neovim is a reasonably big vim fork.

[jony255]

I think this discussion is relevant to the pr I opened earlier today. Should I re-open it or keep it closed?

[gbrlsnchs]

I think this discussion is relevant to the pr I opened earlier today. Should I re-open it or keep it closed?

As a user of both Void and Neovim, my opinion is to reopen and have it merged. noextract seems to be a good way to avoid Neovim files, if that's a problem.