Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: srb2-2.2.6 #21980

Merged
merged 1 commit into from Apr 18, 2021
Merged

New package: srb2-2.2.6 #21980

merged 1 commit into from Apr 18, 2021

Conversation

oreo639
Copy link
Member

@oreo639 oreo639 commented May 15, 2020

No description provided.

@oreo639 oreo639 force-pushed the srb2 branch 4 times, most recently from ad24a9a to 0d98a55 Compare May 15, 2020 08:59
@oreo639 oreo639 force-pushed the srb2 branch 2 times, most recently from 5b0dc82 to 2850f78 Compare July 19, 2020 02:54
@oreo639 oreo639 changed the title New package: srb2-2.2.4 New package: srb2-2.2.6 Jul 19, 2020
@oreo639 oreo639 force-pushed the srb2 branch 3 times, most recently from e56e2e0 to 5ba8053 Compare July 27, 2020 23:05
@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
srcpkgs/srb2/template Outdated Show resolved Hide resolved
srcpkgs/srb2-data/template Outdated Show resolved Hide resolved
srcpkgs/srb2/files/srb2.desktop Outdated Show resolved Hide resolved
srcpkgs/srb2/template Outdated Show resolved Hide resolved
srcpkgs/srb2/template Outdated Show resolved Hide resolved
Comment on lines +35 to +38
PROGRAM_NAME="${pkgname}" PROGRAM_DESCRIPTION="${short_desc}" \
PACKAGE_INSTALL_PATH="/usr/bin" PROGRAM_FILENAME="${pkgname}" \
envsubst < debian-template/srb2.desktop > srb2.desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I did not know about this solution. Cool :)

@the-maldridge
Copy link
Member

I'm concerned that this is not distributable. I suspect that Sega would not approve of their assets being used in a 3rd party works.

@oreo639
Copy link
Member Author

oreo639 commented Feb 21, 2021

Void Linux already distributes opensonic (which does come with assets).
srb2 does allow one to just put the assets in ~/.srb2, so we don't technically have to distribute the assets.
Also, there was a flatpack made after this pull request was opened so it isn't a big deal if this isn't merged.

@the-maldridge
Copy link
Member

We were actually just discussing that on IRC. It seems like opensonic snuck in as it almost certainly isn't distributable either.

@ericonr
Copy link
Member

ericonr commented Feb 21, 2021

@oreo639 if this is accepted, but as a restricted package (not a guarantee, just something I put forward), do you think you'd be up to updating it for new releases, or do you think you'll stick with the flatpak?

If you still want to maintain it, we can keep this open for further pondering, otherwise I believe we should close the PR. Distributing assets is rather messy, and I'm not sure the packaage is very useful without them, with just the executables. What do you think? For the record, we do ship a lot of doom clones and some other games which require external assets.

@oreo639
Copy link
Member Author

oreo639 commented Feb 21, 2021

I would plan to continue updating this package.

The assets for srb2 can be downloaded from a zip file on their github releases page.
The game does check the md5sum of the assets to make sure they are valid for that version of the game.

Personally, I'm not sure. I'm fine with whatever.

ericonr pushed a commit to ericonr/void-packages that referenced this pull request Apr 5, 2021
Closes: void-linux#21980 [via git-merge-pr]
@ericonr
Copy link
Member

ericonr commented Apr 11, 2021

Please make it restricted

@oreo639
Copy link
Member Author

oreo639 commented Apr 11, 2021

Alright, I'll do it tomorrow.

@ericonr ericonr merged commit 9e39c5d into void-linux:master Apr 18, 2021
@oreo639 oreo639 deleted the srb2 branch April 18, 2021 04:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants