Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libglvnd: remove excess devel deps, grep license #22008

Closed
wants to merge 1 commit into from
Closed

libglvnd: remove excess devel deps, grep license #22008

wants to merge 1 commit into from

Conversation

st3r4g
Copy link
Contributor

@st3r4g st3r4g commented May 16, 2020

Tested building glu and mesa

@Chocimier
Copy link
Member

makedepends are usually added to depends of -devel, because headers include headers from that packages. What's different here?

@st3r4g
Copy link
Contributor Author

st3r4g commented May 16, 2020 •
edited
Loading

Sorry, removing all ${makedepends} is wrong, at least libX11-devel is indeed required. In general though not all makedepends necessarily are required as deps for the devel package, I'll see if the other two actually are. Also I should test compiling an actual application doing GLX calls and not just libraries

@st3r4g st3r4g marked this pull request as draft May 16, 2020 10:42
@st3r4g
Copy link
Contributor Author

st3r4g commented May 16, 2020 •
edited
Loading

I think libXext-devel xorgproto are required internally and not propagated to public headers, but meaningful testing is annoying because these are also pulled in by other -devel dependencies (when trying to build e.g. mesa-demos) EDIT: mesa-demos requires xext by itself, so useless to test with it, tested compiling xdriinfo and glmark2 (with MesaLib-devel replaced by libglvnd-devel)

@st3r4g st3r4g force-pushed the libglvnd-remove-devel-deps branch from 727d865 to fbf0819 Compare May 16, 2020 12:42
@st3r4g st3r4g marked this pull request as ready for review May 16, 2020 12:42
@st3r4g st3r4g force-pushed the libglvnd-remove-devel-deps branch from fbf0819 to 37b05f9 Compare May 16, 2020 12:43
@st3r4g st3r4g closed this Oct 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@st3r4g @Chocimier