New package: rm-improved-0.13.1 #22086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenson
reviewed
May 18, 2020
abenson
reviewed
May 18, 2020
|
@abenson comments addresses please check again |
ericonr
reviewed
May 21, 2020
Comment on lines
+13
to
+17
| if [ "$CROSS_BUILD" ]; then | ||
| export HOST_CC="$BUILD_CC" | ||
| export HOST_CFLAGS="$BUILD_CFLAGS" | ||
| export BINDGEN_EXTRA_CLANG_ARGS="--sysroot=$XBPS_CROSS_BASE" | ||
| fi |
There was a problem hiding this comment.
Any reason this is needed specifically for this package but not for others? Could make sense to add it to the build_style.
sgn
reviewed
May 24, 2020
| short_desc="Safe and ergonomic alternative to rm" | ||
| maintainer="Juan <juan@horlux.org>" | ||
| license="GPL-3.0-only" | ||
| homepage="https://github.com/nivekuil/rip" |
There was a problem hiding this comment.
This makes me wonder why don't we name this package rip?
|
Seemingly abandoned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.